Paginate semantic facet requests #161
Assignees
Labels
Awaiting Review
The issue has been deployed and a review is required to close it.
external api change
facet
performance
semantic
system availability
Milestone
Comments
This was referenced May 28, 2024
9 tasks
7 tasks
This was referenced Jun 12, 2024
|
Plan from Team Meeting 06/14/2024:
|
31 tasks
brent-hartwig
added a commit
that referenced
this issue
Jun 27, 2024
…t is being processed per request.
clarkepeterf
pushed a commit
that referenced
this issue
Jun 28, 2024
…t is being processed per request.
brent-hartwig
added a commit
that referenced
this issue
Jul 1, 2024
* 160: facets endpoint now supports option page and pageLength parameters. Said parameters have been implemented for non-semantic facets. Removed some obsolete and extraneous code related to previously supporting multiple facets per request and allowing a search request to also request facets. * 161 - add pagination to via-search facets * 161 - add info about totalItems and next/prev pages to the facets response * add ability to sort non-semantic facets * update simple search to use referenceName instead of referencePrimaryName - also update the advanced search Name fields to use *Name instead of *PrimaryName - except for setPrimaryName because that needs a new index * #160 and #161: documented the facet endpoint's new sort parameter (non-semantic facets only). * 161 - update non-semantic facets to allow up to 10000 results; remove 'first' property from facet response * #160 and #161: updated facets library to better reflect only one facet is being processed per request. * Pagination params checked before passing pageLength into Math.min. * Facet API documentation updates * 161 - add comment giving background for pagination changes * update changelog for 161 and 100 * Worked over more variable names within the facets library. Moved comment explaining recent changes. Restored and added comments. Passed smoke testing --------- Co-authored-by: Peter Clarke <peter.clarke@yale.edu> Co-authored-by: Brent Hartwig <brent_d_hartwig@hotmail.com>
brent-hartwig
added a commit
that referenced
this issue
Jul 1, 2024
clarkepeterf
added
Awaiting Review
|
Approved by UAT |
|
Closing looks good in PROD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Same as #160 but for semantic facets.
Problem Description:
Each facet request returns all of the facet's values, leading to requests taking longer than necessary to process, response sizes being larger than necessary, and contributing to system instability. This ticket's scope is limited to semantic facets.
Expected Behavior/Solution:
Paginate facet requests. Default to 20 facet values. Impose a maximum of 100 values per request.
Until the frontend and middle tier implement facet pagination, the frontend will be limited to the first page of facets, as defined by the backend.
Requirements:
Enable backend endpoint consumers to specify the page and page length. Default to page 1 with a page length of 20.
Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.
- [ ] Wireframe/Mockup - Mike- [ ] Committee discussions - Sarah- [ ] Feasibility/Team discussion - Sarah- [ ] Questions- List of questions for discussions. Answers should be documented within the issue.UAT/LUX Examples:
Dependencies/Blocks:
Related Github Issues:
#160: Same ticket but for non-semantic facets.
#162: Performance test targeting #160 if not also #161
Related links:
None
Wireframe/Mockup:Place wireframe/mockup for the proposed solution at end of ticket.The text was updated successfully, but these errors were encountered: