-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify config instantiation #57
Conversation
Awesome, thank you! Can we just not use Btw, from PL 2.0, Trainer has not |
Assert would also raise an error, right? Do we want to have specific error codes? |
Just style concerns, i think asserts are usually for debugging and testing purposes |
Got it, will make the edit! |
Thanks! Btw how do the error messages look like now, is it better or do we still have to figure that out? |
This fixes it. Those error messages were thrown because we not only instantiated our config, but also called it through monai config. Now these two are de-coupled |
Description
This PR simplifies the instantiation of a configuration by refactoring the existing code and making it more user-friendly. Monai bundle scripts are avoided and configuration parsers are used to separate from monai's structure and error-handling
Related Issue
N/A
Type of Change
Checklist
CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.make codestyle
.