Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add histogram to logger #42

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Add histogram to logger #42

merged 3 commits into from
Feb 23, 2023

Conversation

surajpaib
Copy link
Collaborator

Description

  • Histogram added to logger. Usecase: Probability distributions for predictions, distributions for SSL features etc.
  • Support for tuple data added. See file changes. Model predictions are often tuples

@surajpaib surajpaib requested a review from ibro45 February 20, 2023 09:27
@ibro45
Copy link
Collaborator

ibro45 commented Feb 21, 2023

Awesome, thanks! I see that you renamed the functions to match the ones in the Writer PR, do you just mind putting them into the same utils file as there just so that it's easier to merge it?

@surajpaib
Copy link
Collaborator Author

Missed seeing that, will update!

@surajpaib surajpaib force-pushed the logger_add_histogram branch from f17ff17 to 3a23f97 Compare February 23, 2023 07:27
@ibro45 ibro45 merged commit 12742ac into main Feb 23, 2023
@ibro45 ibro45 deleted the logger_add_histogram branch February 23, 2023 14:54
@ibro45 ibro45 mentioned this pull request Mar 8, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibro45 ibro45 ibro45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surajpaib @ibro45