Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5137] - Fix OCP-Azure-Managed sql + report_data masu endpoint #5486

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Feb 6, 2025

Jira Ticket

COST-5137

Description

This PR has the following changes:

  1. Adds a new managed table for managed_azure_openshift_disk_capacities_temp instead of sharing azure_openshift_disk_capacities_temp with the non-managed flow (They squash each other a little)
  2. Adds some missing SQL logic to handle correctly associating disk capacity line items in the managed_azure_openshift_disk_capacities_temp table
  3. Adds the missing process_openshift_on_cloud_trino call to the report_data (summary) endpoint so this endpoint continue to function like it used too. Running both cloud and ocp on cloud managed summary tasks.

Testing

  1. Checkout Branch
  2. Enable managed table unleash flags
  3. Make load/run IQE smoke tests
  4. Everything should ingest correctly.

Release Notes

  • proposed release note
* [COST-5137](https://issues.redhat.com/browse/COST-5137) Fix missing managed table improvements.

@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Feb 6, 2025
@lcouzens lcouzens requested review from a team as code owners February 6, 2025 15:45
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (0e3a92a) to head (979729f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5486   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        371     371           
  Lines      31644   31651    +7     
  Branches    3388    3389    +1     
=====================================
+ Hits       29769   29776    +7     
  Misses      1219    1219           
  Partials     656     656           

@lcouzens lcouzens merged commit abe1b6e into main Feb 7, 2025
14 checks passed
@lcouzens lcouzens deleted the azure-managed-sql-fixes branch February 7, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants