Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-4096] Migration to add volume handle to PVC topology #5134

Merged
merged 7 commits into from
May 30, 2024

Conversation

myersCody
Copy link
Contributor

Jira Ticket

COST-4096

Description

This change will update the OCP PVC topology table to include the csi_volume_handle.

Migrations for #5132

Testing

  1. Run Migration and see new column.

Release Notes

  • proposed release note
* [COST-4096](https://issues.redhat.com/browse/COST-4096) Migration to add csi volume handle to OCP pvc topology

@myersCody myersCody added django migration Change requires a Django database migration and removed smokes-required labels May 23, 2024
@myersCody myersCody added the skip-migration-check Skip migration test in CI. Useful for separating model changes from the migration. label May 23, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (3dcf7df) to head (04e5c26).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5134     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        376     376             
  Lines      31308   31308             
  Branches    3756    3756             
=======================================
- Hits       29467   29463      -4     
- Misses      1173    1177      +4     
  Partials     668     668             

@myersCody myersCody changed the title [COST-4096] Update OCP pvc topology to include csi_volume_handle [COST-4096] Migration to add volume handle to PVC topology May 29, 2024
@myersCody myersCody marked this pull request as ready for review May 29, 2024 13:22
@myersCody myersCody requested review from a team as code owners May 29, 2024 13:22
@myersCody myersCody added the hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix label May 29, 2024
@myersCody
Copy link
Contributor Author

/retest

@myersCody myersCody merged commit 10cfa85 into main May 30, 2024
11 checks passed
@myersCody myersCody deleted the COST-4096-postgres-migration branch May 30, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django migration Change requires a Django database migration hot-fix-smoke-tests pr_check label to run minimal smoke tests for fast moving bug-fix skip-migration-check Skip migration test in CI. Useful for separating model changes from the migration. smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants