requested changes

project-koku · May 29, 2024 · 1497e3c · 1497e3c
1 parent a59aeb9
commit 1497e3c
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/koku/koku/celery.py b/koku/koku/celery.py
@@ -85,7 +85,7 @@ def readiness_check(self):
         self._write_response(ProbeResponse(status, msg))
 
 
-def validate_cron_expression(expresssion, default):
+def validate_cron_expression(expresssion, default="0 * * * *"):
     if not croniter.is_valid(expresssion):
         print(f"Invalid report-download-schedule {expresssion}. Falling back to default {default}")
         expresssion = default
@@ -114,11 +114,11 @@ def validate_cron_expression(expresssion, default):
 
 # Toggle to enable/disable scheduled checks for new reports.
 if ENVIRONMENT.bool("SCHEDULE_REPORT_CHECKS", default=False):
-    download_expression = "0 * * * *"
+    download_fallback = validate_cron_expression("0 * * * *")
     download_task = "masu.celery.tasks.check_report_updates"
     # The schedule to scan for new reports.
-    REPORT_DOWNLOAD_SCHEDULE = ENVIRONMENT.get_value("REPORT_DOWNLOAD_SCHEDULE", default=download_expression)
-    REPORT_DOWNLOAD_SCHEDULE = validate_cron_expression(REPORT_DOWNLOAD_SCHEDULE, download_expression)
+    download_expression = ENVIRONMENT.get_value("REPORT_DOWNLOAD_SCHEDULE", default=download_fallback)
+    REPORT_DOWNLOAD_SCHEDULE = validate_cron_expression(download_expression, download_fallback)
     report_schedule = crontab(*REPORT_DOWNLOAD_SCHEDULE.split(" ", 5))
     CHECK_REPORT_UPDATES_DEF = {
         "task": download_task,
@@ -175,9 +175,9 @@ def validate_cron_expression(expresssion, default):
 }
 
 # Specify the frequency for pushing source status.
-status_expression = "0 3 * * *"
-SOURCE_STATUS_SCHEDULE = ENVIRONMENT.get_value("SOURCE_STATUS_SCHEDULE", default=status_expression)
-SOURCE_STATUS_SCHEDULE = validate_cron_expression(SOURCE_STATUS_SCHEDULE, default=status_expression)
+status_fallback = validate_cron_expression("0 3 * * *")
+status_expression = ENVIRONMENT.get_value("SOURCE_STATUS_SCHEDULE", default=status_fallback)
+SOURCE_STATUS_SCHEDULE = validate_cron_expression(status_expression, status_fallback)
 source_status_schedule = crontab(*SOURCE_STATUS_SCHEDULE.split(" ", 5))
 
 # task to push source status`