-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Support custom MCAD container image #149
feat(api): Support custom MCAD container image #149
Conversation
/assign @jbusche @KPostOffice @anishasthana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes look good to me. I haven't run through with testing + deploying it, however.
OK, great, let me see if I can test it, see if it works as expected... |
OK - I'm having one small snag, but seeing it also with the main branch, so it's not part of this PR that I can see.
My temporary fix is to edit
|
The testing I've done is this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested out fine - I'll open an issue on the make install
problem, that seems unrelated to this PR.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbusche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #114.