Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kustomize to bundle MCAD CRDs #116

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Use Kustomize to bundle MCAD CRDs #116

merged 2 commits into from
Jun 5, 2023

Conversation

astefanutti
Copy link
Contributor

@astefanutti astefanutti commented May 31, 2023

This PR removes the manual sync of the MCAD CRDs, by pointing Kustomize to the source of truth directly.

It surfaces the dependency on MCAD, with a version that's currently hard-coded.

Requires project-codeflare/multi-cluster-app-dispatcher#401.

Relates to #50.

@openshift-ci
Copy link

openshift-ci bot commented May 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@astefanutti
Copy link
Contributor Author

/assign @anishasthana @sutaakar

config/crd/mcad/kustomization.yaml Outdated Show resolved Hide resolved
@astefanutti astefanutti marked this pull request as ready for review June 2, 2023 08:18
@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2023
Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants