Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Patch operations to update AppWrapper.Status #227

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

dgrove-oss
Copy link
Collaborator

Using Status().Patch(...) is preferred to Status().Update(...) to reduce reconciler conflicts as Update on the subresource still changes the resourceVersion on the root object.

Using Status().Patch(...) is preferred to Status().Update(...)
to reduce reconciler conflicts as Update on the subresource
still changes the resourceVersion on the root object.
@dgrove-oss dgrove-oss added the enhancement New feature or request label Aug 13, 2024
@dgrove-oss dgrove-oss merged commit 4f0f9b7 into project-codeflare:main Aug 13, 2024
2 checks passed
@dgrove-oss dgrove-oss deleted the patchit branch August 13, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant