Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit an event when an unhealthy appwrapper is being reset #207

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

dgrove-oss
Copy link
Collaborator

@dgrove-oss dgrove-oss commented Jul 19, 2024

Since the detailed message for why the workload becomes unhealthy is lost when the condition is cleared on resuming, we should emit it as an event as well.

(base) dgrove@Dave's IBM Mac appwrapper % kubectl get events | grep  appwrapper/sample-failing-job
10m         Normal    CreatedWorkload        appwrapper/sample-failing-job                  Created Workload: default/appwrapper-sample-failing-job-4d7ed
10m         Normal    Started                appwrapper/sample-failing-job                  Admitted by clusterQueue cluster-queue
5m48s       Normal    CreatedWorkload        appwrapper/sample-failing-job                  Created Workload: default/appwrapper-sample-failing-job-9515b
5m48s       Normal    Started                appwrapper/sample-failing-job                  Admitted by clusterQueue cluster-queue
57s         Normal    Unhealthy              appwrapper/sample-failing-job                  FailedComponent: Found 1 failed components
52s         Normal    FinishedWorkload       appwrapper/sample-failing-job                  Workload 'default/appwrapper-sample-failing-job-9515b' is declared finished```

@dgrove-oss dgrove-oss merged commit e76ea7e into project-codeflare:main Jul 19, 2024
2 checks passed
@dgrove-oss dgrove-oss added the enhancement New feature or request label Jul 19, 2024
@dgrove-oss dgrove-oss deleted the events branch November 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant