Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate more things that we always implement via AttributeAccessInterface #17977

Merged
merged 1 commit into from
May 6, 2022
Merged

Annotate more things that we always implement via AttributeAccessInterface #17977

merged 1 commit into from
May 6, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Together with PR #17928 this should be all of them.

Problem

Allocating RAM for things we never read from that RAM.

Change overview

Stop doing that.

Testing

Should be tested by existing tests.

@boring-cyborg boring-cyborg bot added the app label May 2, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2022 •
edited
Loading

PR #17977: Size comparison from 72266d7 to 041297a

Decreases (11 builds for cc13x2_26x2, efr32, esp32, k32w, nrfconnect, p6, telink)
platform target config section 72266d7 041297a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 166728 166720 -8 -0.0
.bss 73548 73540 -8 -0.0
lock-mtd LP_CC2652R7 (read/write) 146352 146344 -8 -0.0
.bss 69268 69260 -8 -0.0
pump-app LP_CC2652R7 (read/write) 183452 183444 -8 -0.0
.bss 73764 73756 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 190364 190356 -8 -0.0
.bss 73820 73812 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 127540 127532 -8 -0.0
.bss 125604 125596 -8 -0.0
window-app BRD4161A (read/write) 133216 133208 -8 -0.0
.bss 131248 131240 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 476936 476928 -8 -0.0
.dram0.bss 73896 73888 -8 -0.0
k32w light k32w061+release (read/write) 684268 684260 -8 -0.0
.bss 81320 81312 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 142000 141996 -4 -0.0
p6 all-clusters-app default .bss 139256 139248 -8 -0.0
telink lighting-app tlsr9518adk80d bss 75432 75428 -4 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 72266d7 041297a change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688935 688935 0 0.0
(read/write) 163320 163320 0 0.0
.bss 75236 75236 0 0.0
.data 3400 3400 0 0.0
.rodata 102303 102303 0 0.0
.text 586148 586148 0 0.0
lock-ftd LP_CC2652R7 (read only) 676783 676783 0 0.0
(read/write) 166728 166720 -8 -0.0
.bss 73548 73540 -8 -0.0
.data 3224 3224 0 0.0
.rodata 94359 94359 0 0.0
.text 581944 581944 0 0.0
lock-mtd LP_CC2652R7 (read only) 625543 625543 0 0.0
(read/write) 146352 146344 -8 -0.0
.bss 69268 69260 -8 -0.0
.data 3224 3224 0 0.0
.rodata 94247 94247 0 0.0
.text 530808 530808 0 0.0
pump-app LP_CC2652R7 (read only) 661299 661299 0 0.0
(read/write) 183452 183444 -8 -0.0
.bss 73764 73756 -8 -0.0
.data 3256 3256 0 0.0
.rodata 80387 80387 0 0.0
.text 580428 580428 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654187 654187 0 0.0
(read/write) 190364 190356 -8 -0.0
.bss 73820 73812 -8 -0.0
.data 3220 3220 0 0.0
.rodata 83323 83323 0 0.0
.text 570380 570380 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626386 626386 0 0.0
.app_xip_area 528920 528920 0 0.0
.bss 80116 80116 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625090 625090 0 0.0
.app_xip_area 529088 529088 0 0.0
.bss 78692 78692 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574226 574226 0 0.0
.app_xip_area 468604 468604 0 0.0
.bss 88016 88016 0 0.0
.data 572 572 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908200 908200 0 0.0
(read/write) 135128 135128 0 0.0
.bss 133072 133072 0 0.0
.data 2052 2052 0 0.0
.text 908192 908192 0 0.0
BRD4161A+rpc (read only) 942544 942544 0 0.0
(read/write) 151808 151808 0 0.0
.bss 149552 149552 0 0.0
.data 2256 2256 0 0.0
.text 942536 942536 0 0.0
BRD4161A+rs911x (read only) 746500 746500 0 0.0
(read/write) 129352 129352 0 0.0
.bss 127372 127372 0 0.0
.data 1980 1980 0 0.0
.text 746492 746492 0 0.0
lock-app BRD4161A+wf200 (read only) 916544 916544 0 0.0
(read/write) 127540 127532 -8 -0.0
.bss 125604 125596 -8 -0.0
.data 1936 1936 0 0.0
.text 916536 916536 0 0.0
window-app BRD4161A (read only) 845448 845448 0 0.0
(read/write) 133216 133208 -8 -0.0
.bss 131248 131240 -8 -0.0
.data 1964 1964 0 0.0
.text 845440 845440 0 0.0
esp32 all-clusters-app c3devkit (read only) 999610 999610 0 0.0
(read/write) 1474506 1474506 0 0.0
.dram0.bss 68376 68376 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207248 207248 0 0.0
.flash.text 999610 999610 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054791 1054791 0 0.0
(read/write) 476936 476928 -8 -0.0
.dram0.bss 73896 73888 -8 -0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 237028 237028 0 0.0
.flash.text 1049407 1049407 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684268 684260 -8 -0.0
.bss 81320 81312 -8 -0.0
.data 2008 2008 0 0.0
.text 599236 599236 0 0.0
lock k32w061+release (read/write) 729148 729148 0 0.0
.bss 81744 81744 0 0.0
.data 1968 1968 0 0.0
.text 643732 643732 0 0.0
linux all-clusters-app debug (read only) 2729977 2729977 0 0.0
(read/write) 173144 173144 0 0.0
.bss 83360 83360 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 235045 235045 0 0.0
.text 2320306 2320306 0 0.0
bridge-app debug+rpc (read only) 1885073 1885073 0 0.0
(read/write) 120440 120440 0 0.0
.bss 71360 71360 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160321 160321 0 0.0
.text 1602354 1602354 0 0.0
chip-tool debug (read only) 8976261 8976261 0 0.0
(read/write) 576464 576464 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546472 546472 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 463061 463061 0 0.0
.text 7190053 7190053 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8816212 8816212 0 0.0
(read/write) 642641 642641 0 0.0
.bss 40913 40913 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581752 581752 0 0.0
.dynamic 560 560 0 0.0
.got 14960 14960 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 430804 430804 0 0.0
.text 6926900 6926900 0 0.0
lighting-app debug+rpc (read only) 2319433 2319433 0 0.0
(read/write) 151392 151392 0 0.0
.bss 73408 73408 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184489 184489 0 0.0
.text 1968690 1968690 0 0.0
lock-app debug (read only) 2225665 2225665 0 0.0
(read/write) 145976 145976 0 0.0
.bss 72032 72032 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194225 194225 0 0.0
.text 1871538 1871538 0 0.0
ota-provider-app debug (read only) 2054209 2054209 0 0.0
(read/write) 138992 138992 0 0.0
.bss 71424 71424 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 174971 174971 0 0.0
.text 1722114 1722114 0 0.0
ota-requestor-app debug (read only) 2085329 2085329 0 0.0
(read/write) 141800 141800 0 0.0
.bss 72064 72064 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171244 171244 0 0.0
.text 1755474 1755474 0 0.0
shell debug (read only) 2554953 2554953 0 0.0
(read/write) 197104 197104 0 0.0
.bss 114088 114088 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216594 216594 0 0.0
.text 2176834 2176834 0 0.0
thermostat-no-ble arm64 (read only) 2360868 2360868 0 0.0
(read/write) 174593 174593 0 0.0
.bss 86273 86273 0 0.0
.data 1496 1496 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145748 145748 0 0.0
.text 1985968 1985968 0 0.0
tv-app debug (read only) 2840769 2840769 0 0.0
(read/write) 276608 276608 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76456 76456 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217035 217035 0 0.0
.text 2441682 2441682 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418060 2418060 0 0.0
.bss 205884 205884 0 0.0
.data 5856 5856 0 0.0
.text 1380660 1380660 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180139 1180139 0 0.0
bss 142000 141996 -4 -0.0
rodata 150804 150804 0 0.0
text 808648 808648 0 0.0
p6 all-clusters-app default (read/write) 2528560 2528560 0 0.0
.bss 139256 139248 -8 -0.0
.data 2792 2792 0 0.0
.text 1486824 1486824 0 0.0
light-app default (read/write) 2419144 2419144 0 0.0
.bss 132720 132720 0 0.0
.data 2592 2592 0 0.0
.text 1377408 1377408 0 0.0
lock-app default (read/write) 2428432 2428432 0 0.0
.bss 132544 132544 0 0.0
.data 2552 2552 0 0.0
.text 1386696 1386696 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807680 807680 0 0.0
bss 75432 75428 -4 -0.0
noinit 40416 40416 0 0.0
text 571300 571300 0 0.0

@pullapprove pullapprove bot requested a review from jtung-apple May 4, 2022 16:07
@bzbarsky-apple bzbarsky-apple force-pushed the more-attribute-access-interface-annotations branch from 041297a to a8510d6 Compare May 5, 2022 18:36
@github-actions
Copy link

github-actions bot commented May 5, 2022 •
edited
Loading

PR #17977: Size comparison from 00ccf44 to a8510d6

Decreases (11 builds for cc13x2_26x2, cyw30739, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section 00ccf44 a8510d6 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 181744 181736 -8 -0.0
.bss 73764 73756 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 188644 188636 -8 -0.0
.bss 73820 73812 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627558 627550 -8 -0.0
.bss 80060 80052 -8 -0.0
esp32 all-clusters-app c3devkit (read/write) 1475322 1475306 -16 -0.0
.dram0.bss 68472 68464 -8 -0.0
k32w light k32w061+release (read/write) 685108 685100 -8 -0.0
.bss 81256 81248 -8 -0.0
lock k32w061+release (read/write) 730448 730440 -8 -0.0
.bss 81688 81680 -8 -0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 205828 205820 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 139684 139680 -4 -0.0
p6 all-clusters-app default .bss 139336 139328 -8 -0.0
lock-app default .bss 132480 132472 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 805996 805988 -8 -0.0
bss 72180 72176 -4 -0.0
Full report (29 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 00ccf44 a8510d6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 690895 690895 0 0.0
(read/write) 161456 161456 0 0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 102943 102943 0 0.0
.text 587468 587468 0 0.0
lock-ftd LP_CC2652R7 (read only) 678467 678467 0 0.0
(read/write) 164988 164988 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94739 94739 0 0.0
.text 583248 583248 0 0.0
lock-mtd LP_CC2652R7 (read only) 627219 627219 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94627 94627 0 0.0
.text 532104 532104 0 0.0
pump-app LP_CC2652R7 (read only) 663007 663007 0 0.0
(read/write) 181744 181736 -8 -0.0
.bss 73764 73756 -8 -0.0
.data 3268 3268 0 0.0
.rodata 80935 80935 0 0.0
.text 581588 581588 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655907 655907 0 0.0
(read/write) 188644 188636 -8 -0.0
.bss 73820 73812 -8 -0.0
.data 3232 3232 0 0.0
.rodata 83891 83891 0 0.0
.text 571532 571532 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627558 627550 -8 -0.0
.app_xip_area 530140 530140 0 0.0
.bss 80060 80052 -8 -0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626454 626454 0 0.0
.app_xip_area 530500 530500 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575198 575198 0 0.0
.app_xip_area 469528 469528 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001018 1001018 0 0.0
(read/write) 1475322 1475306 -16 -0.0
.dram0.bss 68472 68464 -8 -0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 207952 207952 0 0.0
.flash.text 1001018 1001018 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056015 1056015 0 0.0
(read/write) 477736 477736 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 237732 237732 0 0.0
.flash.text 1050631 1050631 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685108 685100 -8 -0.0
.bss 81256 81248 -8 -0.0
.data 2020 2020 0 0.0
.text 600128 600128 0 0.0
lock k32w061+release (read/write) 730448 730440 -8 -0.0
.bss 81688 81680 -8 -0.0
.data 1980 1980 0 0.0
.text 645076 645076 0 0.0
linux all-clusters-app debug (read only) 2739241 2739241 0 0.0
(read/write) 174200 174200 0 0.0
.bss 83680 83680 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82328 82328 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 236005 236005 0 0.0
.text 2328226 2328226 0 0.0
bridge-app debug+rpc (read only) 1893345 1893345 0 0.0
(read/write) 120920 120920 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40584 40584 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161241 161241 0 0.0
.text 1609442 1609442 0 0.0
chip-tool debug (read only) 8981069 8981069 0 0.0
(read/write) 576880 576880 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546656 546656 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 464213 464213 0 0.0
.text 7193253 7193253 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8820516 8820516 0 0.0
(read/write) 643057 643057 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581976 581976 0 0.0
.dynamic 560 560 0 0.0
.got 14968 14968 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431780 431780 0 0.0
.text 6929668 6929668 0 0.0
lighting-app debug+rpc (read only) 2327457 2327457 0 0.0
(read/write) 151872 151872 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70504 70504 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185401 185401 0 0.0
.text 1975538 1975538 0 0.0
lock-app debug (read only) 2234737 2234737 0 0.0
(read/write) 146456 146456 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67032 67032 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 195145 195145 0 0.0
.text 1879426 1879426 0 0.0
ota-provider-app debug (read only) 2063065 2063065 0 0.0
(read/write) 139568 139568 0 0.0
.bss 71680 71680 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60376 60376 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176147 176147 0 0.0
.text 1729218 1729218 0 0.0
ota-requestor-app debug (read only) 2094209 2094209 0 0.0
(read/write) 142376 142376 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62440 62440 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172444 172444 0 0.0
.text 1762578 1762578 0 0.0
shell debug (read only) 2564217 2564217 0 0.0
(read/write) 198096 198096 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76600 76600 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217458 217458 0 0.0
.text 2184850 2184850 0 0.0
thermostat-no-ble arm64 (read only) 2367932 2367932 0 0.0
(read/write) 175057 175057 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79312 79312 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146524 146524 0 0.0
.text 1991856 1991856 0 0.0
tv-app debug (read only) 2849993 2849993 0 0.0
(read/write) 277152 277152 0 0.0
.bss 189464 189464 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218059 218059 0 0.0
.text 2449474 2449474 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419676 2419676 0 0.0
.bss 205828 205820 -8 -0.0
.data 5872 5872 0 0.0
.text 1382276 1382276 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179743 1179743 0 0.0
bss 139684 139680 -4 -0.0
rodata 151504 151504 0 0.0
text 809848 809848 0 0.0
p6 all-clusters-app default (read/write) 2531120 2531120 0 0.0
.bss 139336 139328 -8 -0.0
.data 2808 2808 0 0.0
.text 1489384 1489384 0 0.0
light-app default (read/write) 2421176 2421176 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379440 1379440 0 0.0
lock-app default (read/write) 2430680 2430680 0 0.0
.bss 132480 132472 -8 -0.0
.data 2568 2568 0 0.0
.text 1388944 1388944 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 805996 805988 -8 -0.0
bss 72180 72176 -4 -0.0
noinit 40416 40416 0 0.0
text 572420 572420 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit c1e5b2f into project-chip:master May 6, 2022
@bzbarsky-apple bzbarsky-apple deleted the more-attribute-access-interface-annotations branch May 6, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@jelderton jelderton jelderton approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @jelderton