FRR-BGP Extended Unified Management Framework #23
Conversation
|  | ||
|
|
||
| ### 4.3.2 REST Get Sequence - State/Statistics | ||
|  |
There was a problem hiding this comment.
What is the communication mechanism between translib/transformer and bgpcfgd? I do not see this explained anywhere in the document. Also these flow diagrams need explanation.
There was a problem hiding this comment.
Updated the doc with "docker exec" command.
There was a problem hiding this comment.
There is a mention of event handling in the diagram section 4.1
| ## 3.1 Overview | ||
| The extended unified config and management framework for FRR-BGP in SONiC is represented in below diagram. | ||
|
|
||
|  |
There was a problem hiding this comment.
The state and statistics flow in this diagram does not match with the CLI and REST get flow diagram. In the flow diagrams the response is through bgpcfgd but in this diagram it is shown that the FRR directly talks to management framework. Only one can be right.
There was a problem hiding this comment.
Fixed the diagram, bgpcfgd is not involved for state/stats get.
|
|
||
| 5. KLISH CLI and REST clients provide extensive BGP configurations and hence there should not be any need for BGP configurations via vtysh. | ||
|
|
||
| 6. In bgpcfgd register for Redis DB events for the BGP and other related objects, so as to translate the Redis DB events to FRR-BGP CLI commands to configure FRR-BGP, similarly, separate config daemons can be present to configure individual features like OSPF, BFD..etc |
There was a problem hiding this comment.
By FRR-BGP CLI command, we mean vtysh CLI commands right? If so will the vtysh shell be opened once from bgpcfgd or will it be opened for every single configuration command?
There was a problem hiding this comment.
yes, will check the possibility in bgpcfgd and make the changes accordingly.
There was a problem hiding this comment.
will check and fix accordingly.
|
|
||
| 6. In bgpcfgd register for Redis DB events for the BGP and other related objects, so as to translate the Redis DB events to FRR-BGP CLI commands to configure FRR-BGP, similarly, separate config daemons can be present to configure individual features like OSPF, BFD..etc | ||
|
|
||
| 7. Update /usr/share/sonic/templates/bgpd.conf.j2 template for new FRR-BGP configurations supported in SONiC which will be used by sonic-cfggen to generate /etc/frr/bgpd.conf file. |
There was a problem hiding this comment.
Should we include the template here?
There was a problem hiding this comment.
No, we're just enhancing the existing bgpd.conf.j2 for new configs.
There was a problem hiding this comment.
No, this is well known template file and already being used for BGP neighbors, peer range..etc
|  | ||
|
|
||
| ### 4.2.2 CLI Show Sequence - State/Statistics | ||
|  |
There was a problem hiding this comment.
Diagram shows translib sends a synchronous message to bgpcfgd which in turn runs vtysh command. What is the messaging used between translib and bgpcfgd?
There was a problem hiding this comment.
Fixed the diagram, there is no bgpcfgd involvement for state/stats show.
|
|
||
| 6. For show commands that requires retrieval of state or statistics information the backend callback will fetch the data from FRR-BGP. | ||
|
|
||
| 7. State/stats information is retried from FRR-BGP by issuing a show command to FRR BGP container and the output is returned in JSON format. |
There was a problem hiding this comment.
Not in sync with flow diagram 4.2.2 - it shows translib sends a synchronous message to bgpcfgd to fetch state data.
Also, isn't direct container-to-container communication against SONiC design guidelines?
There was a problem hiding this comment.
This is fixed now.
venkatmahalingam
changed the title
No description provided.