-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append hash of device usage id to device property key name #561
Append hash of device usage id to device property key name #561
Conversation
/version patch |
Signed-off-by: Johnson Shih <jshih@microsoft.com>
Signed-off-by: Johnson Shih <jshih@microsoft.com>
Signed-off-by: Johnson Shih <jshih@microsoft.com>
Signed-off-by: Johnson Shih <jshih@microsoft.com>
Signed-off-by: Johnson Shih <jshih@microsoft.com>
1b778a6
to
b4f2c91
Compare
Signed-off-by: Johnson Shih <jshih@microsoft.com>
I believe this is a breaking change since it will break all existing brokers when they look up properties. We should make this a minor version change and we will need update docs. |
/version minor |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Johnson Shih <jshih@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am concerned about my comment around regenerating random hashes rather than associating properties via an instance's hash
Signed-off-by: Johnson Shih <jshih@microsoft.com>
Signed-off-by: Johnson Shih <jshih@microsoft.com>
Signed-off-by: Johnson Shih <jshih@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this great addition @johnsonshih!
What this PR does / why we need it:
When allocate a device plugin, Agent adds the device properties as the container's environment variables. Currently, when a container uses multiple device plugins, all device plugins will set device properties to the same set of environment variables and only the last one write to the environment variable is recorded. This PR suffix device usage id to the device property key name so the environment variables won't be overwritten.
This PR is part of the fix for issue #492
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)