Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(DecorationNode): improve Inefficient regular expression #519

Merged
merged 2 commits into from
Feb 7, 2021

Conversation

progfay
Copy link
Owner

@progfay progfay commented Feb 7, 2021

Proposed Changes

PoC

const decorationRegExp = /\[[!"#%&'()*+,-./{|}<>_~]+ (?:\[[^\]]+\]|[^\]])+\]/
`[! ${'['.repeat(30000)}z`.match(decorationRegExp) // ReDoS!!!

Changes

- const decorationRegExp = /\[[!"#%&'()*+,-./{|}<>_~]+ (?:\[[^\]]+\]|[^\]])+\]/
+ const decorationRegExp = /\[[!"#%&'()*+,-./{|}<>_~]+ (?:\[[^[\]]+\]|[^\]])+\]/

/\[[^[\]]+\]/ RegExp fail matching for [[ with no back tracking.

@progfay progfay merged commit 47e1706 into master Feb 7, 2021
@progfay progfay deleted the fix-decorationRegExp-ReDos branch February 7, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant