Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Enable local tests with act #23

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

bfhealy
Copy link
Contributor

@bfhealy bfhealy commented Dec 13, 2022

This PR shows the workflow changes that successfully run tdtax tests using act. The ubuntu and action versions are modified according to skyportal/skyportal#3735.

After implementing these changes, the final modification to avoid an error is to run the upload-artifact action only if the environment is not ACT. Otherwise, an error gets raised due to the lack of environment variables (e.g. ACTIONS_RUNTIME_TOKEN) that are specific to GitHub Actions runners. See nektos/act#329 (comment) and nektos/act#285 (comment) for more details.

@profjsb
Copy link
Owner

profjsb commented Dec 13, 2022

This succeeds on the mac ARM chip architectures by running:

act --container-architecture linux/amd64

@profjsb profjsb self-requested a review December 13, 2022 22:33
Copy link
Owner

@profjsb profjsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@profjsb profjsb merged commit cd3fbaf into profjsb:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants