This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
Scroll to newly received message if required #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not scroll if not previously at the bottom of the list. Change-type: patch Signed-off-by: Graham McCulloch <graham@balena.io>
Firstly, some browsers have trouble scrolling smoothly - the scroll never completes. Secondly, when first loading the timeline, it's more useful to scroll immediately to the bottom. This has actually been requested by users. Change-type: minor Signed-off-by: Graham McCulloch <graham@balena.io>
karaxuna
reviewed
Mar 17, 2021
|
|
||
| // We consider it to be at the bottom if we're within 30 pixels of the bottom | ||
| return _.inRange(timelineEndRect.bottom, timelineRect.bottom - 1, timelineRect.bottom + 30) | ||
| } catch (error) { |
There was a problem hiding this comment.
@karaxuna my experience is that React can unset the current property of refs at inconvenient times. It probably isn't needed but I was nervous about not catching an error. Feel free to convince me it is indeed safe though.
There was a problem hiding this comment.
@grahammcculloch I think it will throw if the timelineEnd.current is detached from dom and you call getBoundingClientRect. But maybe it can throw in other cases too, so I'm ok with this.
karaxuna
approved these changes
Mar 18, 2021
|
|
||
| // We consider it to be at the bottom if we're within 30 pixels of the bottom | ||
| return _.inRange(timelineEndRect.bottom, timelineRect.bottom - 1, timelineRect.bottom + 30) | ||
| } catch (error) { |
There was a problem hiding this comment.
@grahammcculloch I think it will throw if the timelineEnd.current is detached from dom and you call getBoundingClientRect. But maybe it can throw in other cases too, so I'm ok with this.
|
@balena-ci rebase |
ghost
force-pushed
the
scroll-to-new-message
branch
from
8c18bb2 to
892122d
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scroll to newly received message if required
Do not scroll if not previously at the bottom of the list.
Change-type: patch
Signed-off-by: Graham McCulloch graham@balena.io
Fixes product-os/jellyfish#5948