Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping Version for Aiohttp #38

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

jianshen92
Copy link
Contributor

@jianshen92 jianshen92 commented Nov 30, 2020

What kind of change does this PR introduce?

aiohttp has introduced a change aio-libs/aiohttp#5056 in 3.7, to always check for transport is closing before deciding to reuse it.

What is the current behavior?

On High Load Occasion, a closing transport sometimes will be reused and such errors will be thrown aio-libs/aiohttp#4587

What is the new behavior?

The latest fix is to always check that transport is not closing before reusing it.

Does this PR introduce a breaking change?

No

Other information

Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianshen92 Thank you for your contribution! LGTM!

@DaleSeo DaleSeo merged commit 6ab30cf into prodigyeducation:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants