Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Actions status badges 🏅 #15

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Github Actions status badges 🏅 #15

merged 1 commit into from
Jan 30, 2020

Conversation

DaleSeo
Copy link
Contributor

@DaleSeo DaleSeo commented Jan 26, 2020

What kind of change does this PR introduce?

docs

What is the current behavior?

No Github Actions status badges

What is the new behavior?

Don't they look cool, are they?

image

Does this PR introduce a breaking change?

No, Just docs

Other information

@DaleSeo DaleSeo added the documentation Improvements or additions to documentation label Jan 26, 2020
@DaleSeo DaleSeo requested a review from steve148 January 26, 2020 18:58
@DaleSeo DaleSeo self-assigned this Jan 26, 2020
@DaleSeo
Copy link
Contributor Author

DaleSeo commented Jan 26, 2020

This PR is blocked due to issue #14.

@xkludge
Copy link
Contributor

xkludge commented Jan 26, 2020

Curious why the ci build says it's failing?

@DaleSeo DaleSeo mentioned this pull request Jan 29, 2020
Merged
steve148
steve148 approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@steve148 steve148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea github actions had an SVG associated with their status, but this is awesome! Thanks @DaleSeo 🙇‍♂️

@DaleSeo DaleSeo merged commit e37454e into master Jan 30, 2020
@DaleSeo DaleSeo deleted the actions-badges branch November 25, 2020 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steve148 steve148 steve148 approved these changes

Assignees

@DaleSeo DaleSeo

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaleSeo @xkludge @steve148