Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: framebuffer cameras uses the size from main canvas #7075

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: framebuffer cameras uses the size from main canvas #7075

merged 1 commit into from
May 29, 2024

Conversation

Vishal2002
Copy link
Contributor

Resolves #7071

Changes:

  • Replaced the this._renderer with (this.renderer||this.fbo) to use either one of them.
  • It will he fix the issue regarding the framebuffer camera using the size of the main canvas.

Screenshots of the change:
Screenshot 2024-05-29 171418

PR Checklist

  • npm run lint passes

davepagurek
davepagurek approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with this fix!

@davepagurek davepagurek merged commit b59caa0 into processing:main May 29, 2024
2 checks passed
@davepagurek
Copy link
Contributor

@all-contributors please add @Vishal2002 for code

@allcontributors allcontributors bot mentioned this pull request May 29, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@davepagurek

I've put up a pull request to add @Vishal2002! 🎉

@yamcodes yamcodes mentioned this pull request Aug 22, 2024
Open
@yamcodes yamcodes mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davepagurek davepagurek davepagurek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cam.ortho() on framebuffer cameras and no args uses the size from the main canvas
2 participants
@Vishal2002 @davepagurek