Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mouse event references #6937

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

nickmcintyre
Copy link
Member

Preparing references in src/events/mouse.js for the new website.

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated

@Qianqianye @davepagurek @limzykenneth

@Qianqianye
Copy link
Contributor

Thanks @nickmcintyre, could you double check the PR to make sure it passes the checks?

@nickmcintyre
Copy link
Member Author

nickmcintyre commented Apr 4, 2024

@Qianqianye they passed locally. It looks like a couple of mouseX and mouseY examples timed out. I don't have permissions to run tests on GitHub–would you please re-run them?

src/events/mouse.js Outdated Show resolved Hide resolved
src/events/mouse.js Outdated Show resolved Hide resolved
@limzykenneth
Copy link
Member

I see you just fixed this as I was leaving the review comment. Will merge once the tests passed.

@nickmcintyre
Copy link
Member Author

@limzykenneth good catch, just noticed this.

@limzykenneth limzykenneth merged commit 0c85acd into processing:main Apr 4, 2024
2 checks passed
@nickmcintyre nickmcintyre deleted the ref-events-mouse branch May 6, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants