Fix filter shaders when rectMode is applied; add tests #6603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6602
Changes:
rect()
instead ofimage()
to avoidrectMode
compatibility issuesrect
implementationScreenshots of the change:
Before:
![image](https://private-user-images.githubusercontent.com/5315059/287405103-5cdbc019-0278-4b57-a89e-3bcd8d52eee4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTc3OTUsIm5iZiI6MTczOTU1NzQ5NSwicGF0aCI6Ii81MzE1MDU5LzI4NzQwNTEwMy01Y2RiYzAxOS0wMjc4LTRiNTctYTg5ZS0zYmNkOGQ1MmVlZTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTgyNDU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTg3Yzc2YjFkMzM0NzhhYzdlZmUxYTBmMzMzMzNjYjk4YjBhY2QzZDdhNWNhZGNhN2E2NThmOWIzNmNhZDZlNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Ngfb2QT_nsWJtHtcjeP1q4Je81AOhGXcQ_0A2jINLCA)
After:
![image](https://private-user-images.githubusercontent.com/5315059/287405127-ecef1cd0-a3f4-4188-9583-e6adcfd5dae6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTc3OTUsIm5iZiI6MTczOTU1NzQ5NSwicGF0aCI6Ii81MzE1MDU5LzI4NzQwNTEyNy1lY2VmMWNkMC1hM2Y0LTQxODgtOTU4My1lNmFkY2ZkNWRhZTYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTgyNDU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDUzNjY0YmMyMzkxN2M2NGU2NjJkNThkMzk4ZjE5YWZkNjE0ZmZlZTFmMTRhOWM4YzAyODcyNjVhOGMzMTE0NCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.G0wL0VM3cF7h2uahRHJSeeZDC8YD1sbM8qkIaRMZivw)
PR Checklist
npm run lint
passes