Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC'21: adding to FES phase 1 #5305

Merged
merged 20 commits into from
Jul 11, 2021
Merged

GSoC'21: adding to FES phase 1 #5305

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
cd29f03
initial changes
Aloneduckling May 21, 2021
bdedb30
initial initial commit
Aloneduckling May 21, 2021
67707db
add printFriendlyStack
Aloneduckling May 22, 2021
6b0d65c
add error templates for Firefox
Aloneduckling May 22, 2021
564f629
added extra urls in readnull and readundefined
Aloneduckling May 26, 2021
a07b678
add friendly error messages and seperate readNullAndUndefined error m…
Aloneduckling Jun 1, 2021
4b56f12
Update friendly error messages
Aloneduckling Jun 16, 2021
f1db41e
add unit tests for new errors
Aloneduckling Jun 16, 2021
ffe2761
add descriptive names to unit tests
Aloneduckling Jun 17, 2021
9eabe2a
Edit unit test names
Aloneduckling Jun 19, 2021
ec3b2b7
unit test failure test
Aloneduckling Jun 19, 2021
63ce561
replace report() with p5._friendlyError()
outofambit Jun 20, 2021
811a836
Merge branch 'main' into pew
Aloneduckling Jun 21, 2021
8991a4a
Merge branch 'processing:main' into pew
Aloneduckling Jun 27, 2021
86561c5
added comments explaning the type of errors
Aloneduckling Jun 28, 2021
f88ca68
update the error messages
Aloneduckling Jun 30, 2021
eabd313
fix minor error which was failing the unit tests
Aloneduckling Jun 30, 2021
fa62b17
update friendly error messages
Aloneduckling Jul 5, 2021
859847f
removed typo and updated the message"
Aloneduckling Jul 6, 2021
8d9964c
refactor global error handlingunit tests
Aloneduckling Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions src/core/friendly_errors/browser_errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@ const strings = {
msg: "Can't find variable: {{}}",
type: 'NOTDEFINED',
browser: 'Safari'
},
{
msg: "Cannot access '{{.}}' before initialization",
type: 'CANNOTACCESS',
browser: 'Chrome'
},
{
msg: "can't access lexical declaration '{{.}}' before initialization",
type: 'CANNOTACCESS',
browser: 'Firefox'
}
],
SyntaxError: [
Expand Down Expand Up @@ -42,13 +52,73 @@ const strings = {
msg: "expected {{.}}, got '{{.}}'",
type: 'UNEXPECTEDTOKEN',
browser: 'Chrome'
},
{
msg: "Identifier '{{.}}' has already been declared",
type: 'REDECLAREDVARIABLE',
browser: 'Chrome'
},
{
msg: 'redeclaration of {} {{.}}',
type: 'REDECLAREDVARIABLE',
browser: 'Firefox'
},
{
msg: 'Missing initializer in const declaration',
type: 'MISSINGINITIALIZER',
browser: 'Chrome'
},
{
msg: 'missing = in const declaration',
type: 'MISSINGINITIALIZER',
browser: 'Firefox'
},
{
msg: 'Illegal return statement',
type: 'BADRETURNORYIELD',
browser: 'Chrome'
},
{
msg: 'return not in function',
type: 'BADRETURNORYIELD',
browser: 'Firefox'
lm-n marked this conversation as resolved.
Show resolved Hide resolved
}
],
TypeError: [
{
msg: '{{.}} is not a function',
type: 'NOTFUNC',
browser: 'all'
},
{
msg: "Cannot read property '{{.}}' of null",
type: 'READNULL',
browser: 'Chrome'
},
{
msg: '{{.}} is null',
type: 'READNULL',
browser: 'Firefox'
},
{
msg: "Cannot read property '{{.}}' of undefined",
type: 'READUDEFINED',
browser: 'Chrome'
},
{
msg: '{{.}} is undefined',
type: 'READUDEFINED',
browser: 'Firefox'
},
{
msg: 'Assignment to constant variable',
type: 'CONSTASSIGN',
browser: 'Chrome'
},
{
msg: "invalid assignment to const '{{.}}'",
type: 'CONSTASSIGN',
browser: 'Firefox'
}
]
};
Expand Down
104 changes: 104 additions & 0 deletions src/core/friendly_errors/fes_core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,38 @@ if (typeof IS_MINIFIED !== 'undefined') {
);
break;
}
case 'REDECLAREDVARIABLE': {
let errSym = matchedError.match[1];
let url =
'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Redeclared_parameter#what_went_wrong';
p5._friendlyError(
translator('fes.globalErrors.syntax.redeclaredVariable', {
symbol: errSym,
url
})
);
break;
}
case 'MISSINGINITIALIZER': {
let url =
'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Missing_initializer_in_const#what_went_wrong';
p5._friendlyError(
translator('fes.globalErrors.syntax.missingInitializer', {
url
})
);
break;
}
case 'BADRETURNORYIELD': {
let url =
'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Bad_return_or_yield#what_went_wrong';
p5._friendlyError(
translator('fes.globalErrors.syntax.badReturnOrYield', {
url
})
);
break;
}
lm-n marked this conversation as resolved.
Show resolved Hide resolved
}
break;
}
Expand Down Expand Up @@ -759,6 +791,23 @@ if (typeof IS_MINIFIED !== 'undefined') {
})
);

if (friendlyStack) printFriendlyStack(friendlyStack);
break;
}
case 'CANNOTACCESS': {
let errSym = matchedError.match[1];
let url =
'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cant_access_lexical_declaration_before_init#what_went_wrong';
p5._friendlyError(
translator('fes.globalErrors.reference.cannotAccess', {
url,
symbol: errSym,
location: locationObj
? translator('fes.location', locationObj)
: ''
})
);

if (friendlyStack) printFriendlyStack(friendlyStack);
break;
}
Expand Down Expand Up @@ -797,6 +846,61 @@ if (typeof IS_MINIFIED !== 'undefined') {
);
}

if (friendlyStack) printFriendlyStack(friendlyStack);
break;
}
case 'READNULL': {
let errSym = matchedError.match[1];
let url1 =
'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cant_access_property#what_went_wrong';
let url2 =
'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/null';
p5._friendlyError(
translator('fes.globalErrors.type.readFromNull', {
url1,
url2,
symbol: errSym,
location: locationObj
? translator('fes.location', locationObj)
: ''
})
);

if (friendlyStack) printFriendlyStack(friendlyStack);
break;
}
case 'READUDEFINED': {
let errSym = matchedError.match[1];
let url1 =
'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cant_access_property#what_went_wrong';
let url2 =
'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/undefined#description';
p5._friendlyError(
translator('fes.globalErrors.type.readFromUndefined', {
url1,
url2,
symbol: errSym,
location: locationObj
? translator('fes.location', locationObj)
: ''
})
);

if (friendlyStack) printFriendlyStack(friendlyStack);
break;
}
case 'CONSTASSIGN': {
let url =
'https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Invalid_const_assignment#what_went_wrong';
p5._friendlyError(
translator('fes.globalErrors.type.constAssign', {
url,
location: locationObj
? translator('fes.location', locationObj)
: ''
})
);

if (friendlyStack) printFriendlyStack(friendlyStack);
break;
}
Expand Down
Loading