Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change loadModel() example #2968

Merged
merged 3 commits into from
Jul 6, 2018
Merged

Change loadModel() example #2968

merged 3 commits into from
Jul 6, 2018

Conversation

TanviKumar
Copy link
Member

Use smaller .obj file for faster loading
Model used is suitable for canvas size of example. (current example is too small)

@TanviKumar
Copy link
Member Author

To resolve #2904

Copy link
Contributor

@almchung almchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new example instead of replacing the old (teapot) example

@TanviKumar
Copy link
Member Author

@almchung Done!

@kjhollen
Copy link
Member

kjhollen commented Jul 3, 2018

hi @TanviKumar, I'm not seeing your updates—can you make sure you've pushed your changes? thanks!

@TanviKumar
Copy link
Member Author

Hey @kjhollen, sorry about that, changes pushed!

@TanviKumar
Copy link
Member Author

@almchung @kjhollen The model() example uses the teapot too. Would it be advisable to change it to the corrected teapot example or the octahedron example in this PR?

@kjhollen
Copy link
Member

kjhollen commented Jul 6, 2018

great! I made one little edit because the word 'teapot' was still hanging around in the alt text for the other example.

@kjhollen kjhollen merged commit 342d0f4 into processing:master Jul 6, 2018
@PAEDevelopment
Copy link

I'm sorry that I'm ignorant of the process here, and don't quite have the skills to contribute, but there are still tiny teapots in the examples and no octahedrons...

@TanviKumar
Copy link
Member Author

@PAEDevelopment , the example code has been changed to reflect the requirement, I believe these changes are yet to be pushed to the site itself and should be in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants