-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme switching to Storybook #2326
Add theme switching to Storybook #2326
Conversation
Trying out this feature with all of the new stories added in #2398 has revealed a bunch of things which are not handled perfectly. TODOs:
|
This is awesome! Its really nice to be able to isolate and explore components with a theme. The One idea for a view with all themes is to mimic Compositions https://bit.cloud/teambit/design/inputs/select Storybook has MDX support so you could use your But these are just ideas for the future. I think whats here is an enhancement by exposing the theme in the first place. It can be iterated on in the future if needed. |
@@ -21,5 +21,9 @@ export const decorators = [ | |||
</MemoryRouter> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like ThemeProvider
has moved to the withThemeProvider HOC. Might need to remove <ThemeProvider>
as well.
Changes:
Could be improved if I make the background fill the entire preview area.
@ofhope - thoughts?
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123