Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compliance-rules/ripple circles: they shouldn't disappear after navigation #4

Open
assynour opened this issue Aug 24, 2022 · 3 comments
Open

Compliance-rules/ripple circles: they shouldn't disappear after navigation #4

assynour opened this issue Aug 24, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@assynour
Copy link
Contributor

assynour commented Aug 24, 2022 •
edited
Loading

The ripple circles disappear after navigation/zooming or after adding a css class. Similar behavior as in #2
@assynour
Copy link
Contributor Author

assynour commented Aug 25, 2022 •
edited
Loading

To reproduce:

  • click on show compliance rules
  • ripple circles appear
  • move the diagram

ripples1

@assynour
Copy link
Contributor Author

assynour commented Aug 25, 2022 •
edited
Loading

To create the ripple circles, I add and animate svg circles to the svg group element of the bpmn activity. The corresponding code is in compliance-rules.js, function addRipleCircles().

@tbouffard tbouffard self-assigned this Aug 25, 2022
@tbouffard tbouffard added the bug Something isn't working label Aug 25, 2022
@tbouffard tbouffard changed the title Compliance-rules/ripple circles Compliance-rules/ripple circles: they shouldn't disappear after navigation Aug 25, 2022
@tbouffard
Copy link
Member

process-analytics/bpmn-visualization-js#2199 may fix this issue and #2

icpm-demo-2022-08-26_18.34.34.mp4

How to reproduce

  • build bpmn-visualization PR 2199 bundles: npm run build-bundles
  • link the local bpmn-visualization npm package: npm link ../bpmn-visualization-js (here, the command assumes that the 2 folders are stored in the same root directory)
  • clear the vite cache (in node_modules/.vite/deps)
  • restart the dev server

@tbouffard tbouffard added this to the Conference Ready milestone Oct 21, 2022
This was referenced Oct 23, 2022
Open
Open
Closed
Closed
@tbouffard tbouffard removed this from the ICPM 2022 Conference Ready milestone Oct 24, 2022
@tbouffard tbouffard mentioned this issue Oct 24, 2022
Open
@assynour assynour mentioned this issue Mar 7, 2023
Open
@tbouffard tbouffard mentioned this issue Oct 10, 2023
Open
@tbouffard tbouffard removed their assignment Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbouffard @assynour