Skip to content
This repository has been archived by the owner on Sep 14, 2019. It is now read-only.

Allow specifying custom file paths #8

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Allow specifying custom file paths #8

merged 1 commit into from
Jun 22, 2018

Conversation

cco3
Copy link
Contributor

@cco3 cco3 commented Jun 14, 2018

This change allows syntax like:

_extends: base:otherdir/test.yml

This is necessary for maintaining an opt-in pattern when we begin
supporting default base repositories.

This change allows syntax like:
```
_extends: base:otherdir/test.yml
```

This is necessary for maintaining an opt-in pattern when we begin
supporting default base repositories.
@cco3
Copy link
Contributor Author

cco3 commented Jun 14, 2018

FYI, @hiimbex

Copy link
Contributor

@bkeepers bkeepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@cco3
Copy link
Contributor Author

cco3 commented Jun 14, 2018

Thanks!

@cco3
Copy link
Contributor Author

cco3 commented Jun 21, 2018

Anything else needed here? Is someone available to merge this?

@hiimbex hiimbex merged commit 1d4d98d into probot:master Jun 22, 2018
@hiimbex
Copy link
Contributor

hiimbex commented Jun 22, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants