Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Drop web builds #120

Closed
wants to merge 2 commits into from
Closed

build: Drop web builds #120

wants to merge 2 commits into from

Conversation

AaronDewes
Copy link
Member

@AaronDewes AaronDewes commented Nov 10, 2023

This package does not make sense in a browser because it depends on "fs".

Now, there apparently has been a new release, so this is technically a breaking change, but the browser build was never working.

This package does not make sense in a browser because it depends on "fs".

This is not marked as a breaking change because the web builds were introduced by probot#117, which was not yet included in a release.
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makes totally sense

@AaronDewes AaronDewes changed the title build: Drop web builds build!: Drop web builds Nov 13, 2023
@AaronDewes AaronDewes changed the title build!: Drop web builds build: Drop web builds Nov 13, 2023
@Uzlopak Uzlopak changed the base branch from main to beta July 20, 2024 23:36
@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 20, 2024

closing in favor of #127

@Uzlopak Uzlopak closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants