Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename PooledQueryBehaviour to QueryBehaviour #65

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

iand
Copy link
Contributor

@iand iand commented Oct 16, 2023

Just simplifies this name a bit since we don't currently have a non-pooled query behaviour

@dennis-tra
Copy link
Contributor

Makes sense and looks good 👍

@dennis-tra
Copy link
Contributor

dennis-tra commented Oct 16, 2023

The changeset does not contain any changes to code comments (only the immediate function comments). I don't know if we mentioned the "PooledQueryBehaviour" somewhere but perhaps worth checking if you haven't already done so. I'm thinking of the extensive prose we put above some interfaces.

@iand
Copy link
Contributor Author

iand commented Oct 16, 2023

The changeset does not contain any changes to code comments (only the immediate function comments). I don't know if we mentioned the "PooledQueryBehaviour" somewhere but perhaps worth checking if you haven't already done so. I'm thinking of the extensive prose we put above some interfaces.

https://github.com/plprobelab/zikade/pull/65/files#diff-1a93358e6a0a163ecc719f914964fa26560aa803d6a9bdc42bf6e7fb059412d4R110 and https://github.com/plprobelab/zikade/pull/65/files#diff-1a93358e6a0a163ecc719f914964fa26560aa803d6a9bdc42bf6e7fb059412d4R140 are code comments with changes

@dennis-tra
Copy link
Contributor

Sorry, I added my qualifier only the immediate function comments a few seconds after I posted the comment.

@dennis-tra
Copy link
Contributor

Let's merge 👍

@iand iand merged commit 5f437c6 into main Oct 16, 2023
7 checks passed
@iand iand deleted the rename-querybehaviour branch October 16, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants