Skip to content

Commit

Permalink
Merge pull request #23 from probcomp/bump-base-image
Browse files Browse the repository at this point in the history
bump base image to fix tornado error
  • Loading branch information
avinson authored Oct 18, 2018
2 parents 7601958 + dbf0c64 commit 11a5034
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# jupyter project recommends pinning the base image: https://github.com/jupyter/docker-stacks#other-tips-and-known-issues
FROM jupyter/minimal-notebook:92fe05d1e7e5
FROM jupyter/minimal-notebook:6d2a05346196

# jupyter project recently removed support for python2, we'll recreate it using their commit as a guide
# https://github.com/jupyter/docker-stacks/commit/32b3d2bec23bc46fab1ed324f04a0ad7a7c73747#commitcomment-24129620
Expand Down Expand Up @@ -37,7 +37,7 @@ RUN pip install kernda --no-cache && \
pip uninstall kernda -y

# add custom css/logo and tutorials (use a skeleton directory in case a bind mount is used)
COPY files/custom/ /usr/local/etc/skel/jupyter/.jupyter/custom/
COPY files/skel/dot_jupyter/ /usr/local/etc/skel/jupyter/.jupyter/
COPY tutorials/ /usr/local/etc/skel/jupyter/tutorials
RUN chown -R $NB_USER /usr/local/etc/skel/jupyter

Expand All @@ -64,4 +64,4 @@ COPY files/docker-entrypoint.sh /usr/local/bin/
ENV PATH $CONDA_DIR/envs/python2/bin:$PATH

ENTRYPOINT ["tini", "--", "docker-entrypoint.sh"]
CMD ["start-notebook.sh"]
CMD ["start-notebook.sh", "--NotebookApp.custom_display_url=http://localhost:8888"]
1 change: 1 addition & 0 deletions files/conda_python2.txt
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,6 @@ six=1.10.*
sqlalchemy=1.1*
statsmodels=0.6.*
sympy=1.0*
tornado=4.5.3
vincent=0.4.*
xlrd
File renamed without changes.
File renamed without changes

0 comments on commit 11a5034

Please sign in to comment.