Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Infer dynamically the version, license and readme of skore #465

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

thomass-dev
Copy link
Collaborator

@thomass-dev thomass-dev commented Oct 9, 2024

$ cd skore/
$ python -m build
Successfully built skore-0.0.0+unknown.tar.gz and skore-0.0.0+unknown-py3-none-any.whl

To locally build a package with a version other than the default 0.0.0+unknown:

$ cd skore/
$ echo "X.Y.Z" > VERSION.txt
$ python -m build
Successfully built skore-X.Y.Z.tar.gz and skore-X.Y.Z-py3-none-any.whl

@thomass-dev thomass-dev changed the title chore(build): Improve building by infering dynamically the version, license and readme of skore chore(build): Infer dynamically the version, license and readme of skore Oct 9, 2024
@thomass-dev thomass-dev force-pushed the remove-version-file branch 5 times, most recently from 12022f5 to 8f5d22d Compare October 9, 2024 09:25
@thomass-dev thomass-dev marked this pull request as ready for review October 9, 2024 09:35
Copy link
Contributor

@rouk1 rouk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

@rouk1 rouk1 merged commit 91ff22e into main Oct 10, 2024
12 checks passed
@rouk1 rouk1 deleted the remove-version-file branch October 10, 2024 07:56
thomass-dev added a commit that referenced this pull request Dec 2, 2024
…ore (#465)

```bash
$ cd skore/
$ python -m build
Successfully built skore-0.0.0+unknown.tar.gz and skore-0.0.0+unknown-py3-none-any.whl
```
---

To locally build a package with a version other than the default
`0.0.0+unknown`:

```bash
$ cd skore/
$ echo "X.Y.Z" > VERSION.txt
$ python -m build
Successfully built skore-X.Y.Z.tar.gz and skore-X.Y.Z-py3-none-any.whl
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants