-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Hide progress bar after execution #1252
Conversation
…cution-is-done feat: hide progress bar after execution
@@ -43,6 +43,7 @@ def wrapper(*args, **kwargs): | |||
), | |||
TextColumn("[orange1]{task.percentage:>3.0f}%"), | |||
expand=False, | |||
transient=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use pre-commit
to lint your file :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay trying it :)
@glemaitre it seems to broke doctest, since there is no more output. |
Indeed. @ictorv Would you mind to fix those docstring. You need to remove the part that are related to the bar. I'll give a quick try locally. |
Yeah Surely 😊 |
@@ -43,6 +43,7 @@ def wrapper(*args, **kwargs): | |||
), | |||
TextColumn("[orange1]{task.percentage:>3.0f}%"), | |||
expand=False, | |||
transient=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be what ruff
would do ;)
transient=True | |
transient=True, |
So, in terms of behaviour, we get what we want. So once the docstrings are fix. I'll be fine with the change. |
Okay fixing dockstring. |
Closed in favor of #1254 |
closes #1251
Hide the progress bar after the execution to free some space in the output in notebook.