Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hide progress bar after execution #1252

Closed
wants to merge 2 commits into from
Closed

Conversation

ictorv
Copy link
Contributor

@ictorv ictorv commented Jan 29, 2025

closes #1251

Hide the progress bar after the execution to free some space in the output in notebook.

@@ -43,6 +43,7 @@ def wrapper(*args, **kwargs):
),
TextColumn("[orange1]{task.percentage:>3.0f}%"),
expand=False,
transient=True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pre-commit to lint your file :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay trying it :)

@thomass-dev
Copy link
Collaborator

@glemaitre it seems to broke doctest, since there is no more output.

Copy link
Contributor

Documentation preview @ d297b58

@glemaitre glemaitre changed the title feat: hide progress bar after execution feat: Hide progress bar after execution Jan 29, 2025
@glemaitre
Copy link
Member

Indeed. @ictorv Would you mind to fix those docstring. You need to remove the part that are related to the bar.

I'll give a quick try locally.

@ictorv
Copy link
Contributor Author

ictorv commented Jan 29, 2025

Indeed. @ictorv Would you mind to fix those docstring. You need to remove the part that are related to the bar.

I'll give a quick try locally.

Yeah Surely 😊

@@ -43,6 +43,7 @@ def wrapper(*args, **kwargs):
),
TextColumn("[orange1]{task.percentage:>3.0f}%"),
expand=False,
transient=True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be what ruff would do ;)

Suggested change
transient=True
transient=True,

@glemaitre
Copy link
Member

So, in terms of behaviour, we get what we want. So once the docstrings are fix. I'll be fine with the change.

@ictorv
Copy link
Contributor Author

ictorv commented Jan 29, 2025

So, in terms of behaviour, we get what we want. So once the docstrings are fix. I'll be fine with the change.

Okay fixing dockstring.

@thomass-dev
Copy link
Collaborator

Closed in favor of #1254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enh: hide progress bar once the execution is done
3 participants