-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(OSX): Matplotlib backend leaks in App Switcher #1232
Conversation
Coverage Report for backend
|
And if it happen not in the main thread, then it makes a segfault ;) |
14d5de7
to
c4c0a5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @rouk1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted @rouk1 , thanks!
Whoops some conflicts ;) |
Conflicts have been resolved. |
When the
![Screenshot 2025-01-27 at 14 43 24](https://private-user-images.githubusercontent.com/892304/406944646-716f0458-1198-4493-ab2d-f21879fe927d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NTQ5OTEsIm5iZiI6MTczODg1NDY5MSwicGF0aCI6Ii84OTIzMDQvNDA2OTQ0NjQ2LTcxNmYwNDU4LTExOTgtNDQ5My1hYjJkLWYyMTg3OWZlOTI3ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNlQxNTExMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lY2UyOGVhYTEzYTE4Y2MyYjk0YTdlNzhjOWVmNWNhYzcwM2Q4ODliOWFmMmJiZDhjMTk5NTU2MTIwYjM3MDI0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.630MipNcjh-gadD56rwUFP9EZi4xMqWebO6vJ2811yE)
figure
property ofMatplotlibFigureItem
is invoked, joblib reloads the plot and instantiate the figure.If the backend is OSX and the figure is not released then a headless window is created and never dies.
This PR introduces a context switcher that forces the property to be called with the agg backend.