fix: Make reports pickable out-of-the-box #1179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the
EstimatorReport
andCrossValidationReport
are pickable object.Right now, because we kept the step of the
Progress
from rich that has a lock, the object are not pickable. I reset the_parent_progress
and_progress_info
toNone
in the finally of the decorator.An alternative is to change the
set_state
but here I think that we can just applied this clean-up instead.