Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project keys must be strings #362

Closed
augustebaum opened this issue Sep 19, 2024 · 0 comments · Fixed by #363 or #368
Closed

Project keys must be strings #362

augustebaum opened this issue Sep 19, 2024 · 0 comments · Fixed by #363 or #368

Comments

@augustebaum
Copy link
Contributor

Currently project.put(1, "hello") works, as well as project.put(set(), "hello"). However, then the serialization of the project for displaying in the frontend fails, because set is unhashable.

We should raise an error when the key is not a string.
augustebaum pushed a commit that referenced this issue Sep 19, 2024
@auguste-probabl
Make it a TypeError when Project.put receives a non-string key
fe3ad03 
Closes #362
@augustebaum augustebaum mentioned this issue Sep 19, 2024
Merged
augustebaum pushed a commit that referenced this issue Sep 19, 2024
@auguste-probabl
Make it a TypeError when Project.put receives a non-string key
352c343 
Closes #362
augustebaum pushed a commit that referenced this issue Sep 20, 2024
@auguste-probabl
Raise an error if key is not a string in project.put(key, value)
01cb886 
- Add error type `KeyTypeError`

Closes #362
@augustebaum augustebaum linked a pull request Sep 20, 2024 that will close this issue
362 project keys must be strings #368
Merged
augustebaum pushed a commit that referenced this issue Sep 23, 2024
@auguste-probabl
Make it a TypeError when Project.put receives a non-string key
61f0a10 
Closes #362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@augustebaum