Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export: choosing the file path and file name #332

Closed
sylvaincom opened this issue Sep 11, 2024 · 6 comments
Closed

Export: choosing the file path and file name #332

sylvaincom opened this issue Sep 11, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@sylvaincom
Copy link
Contributor

sylvaincom commented Sep 11, 2024

Issue

When exporting a dashboard, it is not possible to choose the file path neither choose the file name.

Expectation

I would like to be able to choose the file path and file name.

@sylvaincom sylvaincom added the enhancement New feature or request label Sep 11, 2024
@sylvaincom sylvaincom changed the title Export file path Export: choosing the file path and file name Sep 11, 2024
@rouk1
Copy link
Contributor

rouk1 commented Sep 16, 2024

Setting the download path is not supported by the web platform.
When #303 will be merged you'll be able to set you desired filename. That will be suffixed .html if not already present.
For now we do not
Screenshot 2024-09-16 at 10 37 23
have custom modals so a standard dialog as been used.

@tuscland
Copy link
Member

Reports will have a key (#334). I suggest we derive a sane name from the key, and append a nicely formatted timestamp.

@tuscland
Copy link
Member

@rouk1 when I export something from Notion, the web browser gives me the opportunity to name the file to my taste and choose the location where to save it.

@rouk1
Copy link
Contributor

rouk1 commented Sep 19, 2024

@rouk1 when I export something from Notion, the web browser gives me the opportunity to name the file to my taste and choose the location where to save it.

This a settings from your browser. On my machine firefox/chrome saves directly to ~/Downloads.
In firefox this is a settings. https://support.mozilla.org/en-US/kb/where-find-and-manage-downloaded-files-firefox#w_change-where-downloads-are-saved
In chrome as well. https://support.google.com/chrome/answer/95759?hl=en&co=GENIE.Platform%3DDesktop#zippy=%2Cchange-download-locations

As far as I know there is no cross browser way to open a save as dialog. There is a proposal from W3C but it's still a draft.

FOr now we can only rely on the download attribute which is use in the saveBlob function.

@rouk1
Copy link
Contributor

rouk1 commented Sep 23, 2024

Note that a experimental API is here : https://developer.mozilla.org/en-US/docs/Web/API/Window/showSaveFilePicker

@tuscland
Copy link
Member

Thanks, it looks promising, though I see it is only implemented in Chrome.

Let's start work on #334 first, and give the exported file a sensible name as suggested here.

@rouk1 rouk1 closed this as completed Oct 2, 2024
thomass-dev pushed a commit that referenced this issue Oct 3, 2024
## This PR allows user to create/duplicate/edit & delete views.

### Backend

All project endpoints are now below the same prefix.

- `GET /api/project/items` lists all items of a project.
- `POST /api/project/views/share/{key}` returns a static shareable HTML
file named `{view name}-{yyyy-MM-dd-HH-mm}.html`.
- `PUT /api/project/views/{key}` save a view in the project.
- `DELETE /api/project/views/{key}` delete a view from the project.

### Frontend

- A new `EditableList` component as been implemented to manage views. 
- A lot of renaming to get rid of the concept of "report".
- Plug everything to the new layout.
- Rework view card layout and add an action dropdown to it.
- Rework dropdowns using floating UI to make them fixed.


https://github.com/user-attachments/assets/3f94e483-ecea-4d5a-8433-50f9150fc6e6


Co-authored with @augustebaum.
Fixes #336, #407, #377, #332

---------

Co-authored-by: Auguste Baum <auguste@probabl.ai>
Co-authored-by: Auguste Baum <52001167+augustebaum@users.noreply.github.com>
thomass-dev pushed a commit that referenced this issue Dec 2, 2024
## This PR allows user to create/duplicate/edit & delete views.

### Backend

All project endpoints are now below the same prefix.

- `GET /api/project/items` lists all items of a project.
- `POST /api/project/views/share/{key}` returns a static shareable HTML
file named `{view name}-{yyyy-MM-dd-HH-mm}.html`.
- `PUT /api/project/views/{key}` save a view in the project.
- `DELETE /api/project/views/{key}` delete a view from the project.

### Frontend

- A new `EditableList` component as been implemented to manage views. 
- A lot of renaming to get rid of the concept of "report".
- Plug everything to the new layout.
- Rework view card layout and add an action dropdown to it.
- Rework dropdowns using floating UI to make them fixed.


https://github.com/user-attachments/assets/3f94e483-ecea-4d5a-8433-50f9150fc6e6


Co-authored with @augustebaum.
Fixes #336, #407, #377, #332

---------

Co-authored-by: Auguste Baum <auguste@probabl.ai>
Co-authored-by: Auguste Baum <52001167+augustebaum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants