no more report

probabl-ai · Oct 2, 2024 · fe836d2 · fe836d2
1 parent ae049db
commit fe836d2
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 15 deletions.
diff --git a/frontend/src/ShareApp.vue b/frontend/src/ShareApp.vue
@@ -1,16 +1,19 @@
 <script setup lang="ts">
 import Simplebar from "simplebar-vue";
 
-import ReportCanvas from "@/components/ProjectViewCanvas.vue";
+import ProjectViewCanvas from "@/components/ProjectViewCanvas.vue";
+import { useProjectStore } from "@/stores/project";
+
+const projectStore = useProjectStore();
 </script>
 
 <template>
   <div class="share">
     <div class="share-header">
-      <h1>Report</h1>
+      <h1>{{ projectStore.currentView }}</h1>
     </div>
     <Simplebar class="canvas-wrapper">
-      <ReportCanvas :showCardActions="false" />
+      <ProjectViewCanvas :showCardActions="false" />
     </Simplebar>
   </div>
 </template>

diff --git a/frontend/src/router.ts b/frontend/src/router.ts
@@ -3,7 +3,7 @@ import { createRouter, createWebHashHistory } from "vue-router";
 import ProjectView from "./views/ProjectView.vue";
 
 export enum ROUTE_NAMES {
-  REPORT_BUILDER = "report-builder",
+  VIEW_BUILDER = "view-builder",
   COMPONENTS = "components",
 }
 
@@ -12,7 +12,7 @@ const router = createRouter({
   routes: [
     {
       path: "/",
-      name: "report-builder",
+      name: "view-builder",
       component: ProjectView,
     },
     {

diff --git a/frontend/src/stores/project.ts b/frontend/src/stores/project.ts
@@ -58,8 +58,7 @@ export const useProjectStore = defineStore("project", () => {
   }
 
   /**
-   * Fetch all reports URI
-   * and eventually the detail of the currently selected view
+   * Fetch project data from the backend.
    */
   let _isCanceledCall = false;
   async function fetch() {

diff --git a/frontend/src/views/ProjectView.vue b/frontend/src/views/ProjectView.vue
@@ -21,7 +21,7 @@ const isInFocusMode = ref(false);
 const views = ref<EditableListItemModel[]>([]);
 let unsavedViewsIds: string[] = [];
 
-async function onShareReport() {
+async function onShareView() {
   const currentView = projectStore.currentView;
   if (currentView) {
     const shareable = await fetchShareableBlob(currentView);
@@ -170,7 +170,7 @@ onBeforeUnmount(() => {
         <div class="editor-header">
           <SimpleButton icon="icon-maximize" @click="onFocusMode" />
           <h1>{{ projectStore.currentView }}</h1>
-          <SimpleButton label="Share report" @click="onShareReport" :is-primary="true" />
+          <SimpleButton label="Share view" @click="onShareView" :is-primary="true" />
         </div>
         <div class="drop-indicator" :class="{ visible: isDropIndicatorVisible }"></div>
         <Transition name="fade">

diff --git a/frontend/tests/views/ProjectView.spec.ts b/frontend/tests/views/ProjectView.spec.ts
@@ -5,7 +5,7 @@ import { createApp } from "vue";
 import { useRoute } from "vue-router";
 
 import { ROUTE_NAMES } from "@/router";
-import ReportBuilderView from "@/views/ProjectView.vue";
+import ProjectView from "@/views/ProjectView.vue";
 import { mountSuspense } from "../test.utils";
 
 vi.mock("@/services/api", () => {
@@ -22,7 +22,7 @@ vi.hoisted(() => {
   window.URL.revokeObjectURL = mockObjectURL;
 });
 
-describe("ReportBuilderView", () => {
+describe("ProjectView", () => {
   beforeEach(() => {
     vi.mock("vue-router");
 
@@ -38,18 +38,18 @@ describe("ReportBuilderView", () => {
 
   it("Renders properly", async () => {
     vi.mocked(useRoute).mockImplementationOnce(() => ({
-      fullPath: `/${ROUTE_NAMES.REPORT_BUILDER}`,
-      path: `/${ROUTE_NAMES.REPORT_BUILDER}`,
+      fullPath: `/${ROUTE_NAMES.VIEW_BUILDER}`,
+      path: `/${ROUTE_NAMES.VIEW_BUILDER}`,
       query: {},
       params: {},
       matched: [],
-      name: ROUTE_NAMES.REPORT_BUILDER,
+      name: ROUTE_NAMES.VIEW_BUILDER,
       hash: "",
       redirectedFrom: undefined,
       meta: {},
     }));
 
-    const builder = await mountSuspense(ReportBuilderView);
+    const builder = await mountSuspense(ProjectView);
     // i.e. not a `VueError`
     expect(builder).toBeInstanceOf(VueWrapper);
   });