feat(watch): --include & --exclude CLI flags
#561
Conversation
Co-authored-by: hiroki osame <hiroki.osame@gmail.com>
| const file = 'file'; | ||
| const value = 'test'; | ||
| const append = `${value}append`; | ||
| const fixture = await createFixture({ |
There was a problem hiding this comment.
Use the await using syntax so you can remove the fixture.rm() below
| expect(tsxProcessResolved.stdout).not.toMatch(`current date: ${value}`); | ||
| expect(tsxProcessResolved.stderr).toBe(''); | ||
| }, 10_000); | ||
| }); |
There was a problem hiding this comment.
Can you add a test for exclude?
| } | ||
| }); | ||
| `.trim(), | ||
| [file]: `${value}`, |
There was a problem hiding this comment.
| [file]: `${value}`, | |
| [file]: value, |
| const append = `${value}append`; | ||
| const fixture = await createFixture({ | ||
| [entryFile]: ` | ||
| import fs from 'fs'; |
There was a problem hiding this comment.
| import fs from 'fs'; | |
| import fs from 'fs/promises'; |
| const entryFile = 'index.js'; | ||
| const file = 'file'; | ||
| const value = 'test'; | ||
| const append = `${value}append`; |
There was a problem hiding this comment.
I see you're trying to couple these together via variables but I think the test will be much more readable if you just hard-code them
privatenumber
changed the title
--include & --exclude CLI flags
|
@boxizen @privatenumber - I'm interested in these changes. Is there any way I could help here? I cannot push directly to this branch since it is on boxizen's repo, but I could create a new branch that continues from this one if boxizen doesn't have time. The code review comments all look easy enough to address (also, TIL that TS5.2 already introduced support for |
|
Closing as it was implemented via #625 |
closes #181
This change adds additional files to the watchlist via adding the
addparameter.