An alias '*': ['src/*'] and import '.' in node_modules resolves src/index.tsx unexpectedly

[JounQin]

As title

More detail prettier/plugin-pug#398

[yi-ge]

esm-loader support index in dir, but it didn't work

[JounQin]

Maybe should report to https://github.com/esbuild-kit/esm-loader instead then?

cc @privatenumber

[privatenumber]

I tried reproducing this but no luck. Also don't know what command you ran to make tsx read from a prettier plugin.

Can you provide a minimal reproduction repository?

[JounQin]

Also don't know what command you ran to make tsx read from a prettier plugin.

@privatenumber

I call prettier's API in a script scripts/run.ts:

import prettier from 'prettier'

await prettier.resolveConfig(process.cwd())

Then yarn tsx scripts/run.ts, make sure you have @prettier/plugin-pug installed.

[privatenumber]

Yup, works fine for me.

[JounQin]

OK, I will try to create a reproduction then.

[JounQin]

@privatenumber

https://github.com/JounQin/test/tree/tsx

run yarn && yarn api

$ tsx scripts/api
/Users/JounQin/Workspaces/GitHub/test/src/index.tsx:1
console.log(document)
            ^

ReferenceError: document is not defined
    at Object.<anonymous> (/Users/JounQin/Workspaces/GitHub/test/src/index.tsx:1:13)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.h (/Users/JounQin/Workspaces/GitHub/test/node_modules/@esbuild-kit/cjs-loader/dist/index.js:1:733)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/Users/JounQin/Workspaces/GitHub/test/node_modules/@prettier/plugin-pug/src/options/common.ts:2:1)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.h (/Users/JounQin/Workspaces/GitHub/test/node_modules/@esbuild-kit/cjs-loader/dist/index.js:1:733)
error Command failed with exit code 1.

[privatenumber]

I'll leave this open till I add a test to prevent this, but should be fixed via https://github.com/privatenumber/get-tsconfig/releases/tag/v4.0.5

Run npm update or reinstall tsx.

[JounQin]

@privatenumber Thanks, it's working as expected now.

[privatenumber]

🎉 This issue has been resolved in version 3.5.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀