wip

privatenumber · Jan 7, 2025 · 831cd6e · 831cd6e
1 parent db837d0
commit 831cd6e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/tests/fixtures.ts b/tests/fixtures.ts
@@ -259,19 +259,19 @@ export const fixtureDynamicImports: FileTree = {
 };
 
 // https://github.com/privatenumber/pkgroll/issues/104
-export const fixtureDynamicImportsError: FileTree = {
+export const fixtureDynamicImportUnresolvable: FileTree = {
 	'package.json': createPackageJson({
 		main: './dist/dynamic-imports.js',
 	}),
 	src: {
 		'dynamic-imports.js': outdent`
 		function importModule(path) {
-  			// who knows what will be imported here?
-  			return import(path);
+			// who knows what will be imported here?
+			return import(path);
 		}
 
-		importModule('./should-fail.js');
-	`,
-		'should-fail.js': 'console.log(123)',
+		importModule('./too-dynamic.js');
+		`,
+		'too-dynamic.js': 'console.log(123)',
 	},
 };
diff --git a/tests/specs/builds/output-commonjs.ts b/tests/specs/builds/output-commonjs.ts
@@ -4,7 +4,7 @@ import { createFixture } from 'fs-fixture';
 import { pkgroll } from '../../utils.js';
 import {
 	packageFixture, createPackageJson, createTsconfigJson, fixtureDynamicImports,
-	fixtureDynamicImportsError,
+	fixtureDynamicImportUnresolvable,
 } from '../../fixtures.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
@@ -207,9 +207,9 @@ export default testSuite(({ describe }, nodePath: string) => {
 		});
 
 		// https://github.com/privatenumber/pkgroll/issues/104
-		test('dynamic imports warning', async () => {
+		test('unresolvable dynamic import should not fail', async () => {
 			await using fixture = await createFixture({
-				...fixtureDynamicImportsError,
+				...fixtureDynamicImportUnresolvable,
 				'package.json': createPackageJson({
 					exports: './dist/dynamic-imports.cjs',
 				}),

diff --git a/tests/specs/builds/output-module.ts b/tests/specs/builds/output-module.ts
@@ -4,7 +4,7 @@ import { createFixture } from 'fs-fixture';
 import { pkgroll } from '../../utils.js';
 import {
 	packageFixture, createPackageJson, createTsconfigJson, fixtureDynamicImports,
-	fixtureDynamicImportsError,
+	fixtureDynamicImportUnresolvable,
 } from '../../fixtures.js';
 
 export default testSuite(({ describe }, nodePath: string) => {
@@ -275,9 +275,9 @@ export default testSuite(({ describe }, nodePath: string) => {
 		});
 
 		// https://github.com/privatenumber/pkgroll/issues/104
-		test('dynamic imports warning', async () => {
+		test('unresolvable dynamic import should not fail', async () => {
 			await using fixture = await createFixture({
-				...fixtureDynamicImportsError,
+				...fixtureDynamicImportUnresolvable,
 				'package.json': createPackageJson({
 					exports: './dist/dynamic-imports.mjs',
 				}),