Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enqueue the following steps is wrong #50

Closed
annevk opened this issue Jun 9, 2020 · 1 comment · Fixed by #70
Closed

Enqueue the following steps is wrong #50

annevk opened this issue Jun 9, 2020 · 1 comment · Fixed by #70
Assignees
@hober
Labels
needs edit This issue is waiting on a PR to be written.

Comments

@annevk
Copy link
Collaborator

annevk commented Jun 9, 2020

This needs to queue a task.
@annevk annevk mentioned this issue Jun 9, 2020
Merged
@hober hober self-assigned this Jul 6, 2020
@hober hober added the needs edit This issue is waiting on a PR to be written. label Aug 10, 2020
@johannhof johannhof mentioned this issue Jan 19, 2021
Closed
johannhof added a commit to johannhof/storage-access that referenced this issue Feb 4, 2021
@johannhof
Fix async steps in hasStorageAccess and requestStorageAccess.
807ad4b 
Fixes privacycg#50, privacycg#69

This is based on some of Anne's feedback around how we run async steps
in parallel and queue tasks for resolving promises instead of what we
were doing before.

This also moves a bunch of things that probably don't need to happen
in parallel (and don't happen in parallel in at least Gecko and WebKit)
out of the async steps.
@johannhof johannhof mentioned this issue Feb 4, 2021
Merged
@Dinh710
Copy link

Dinh710 commented Feb 9, 2021

VN.GLOVES

johannhof added a commit to johannhof/storage-access that referenced this issue Feb 12, 2021
@johannhof
Fix async steps in hasStorageAccess and requestStorageAccess.
61e7c8d 
Fixes privacycg#50, privacycg#69

This is based on some of Anne's feedback around how we run async steps
in parallel and queue tasks for resolving promises instead of what we
were doing before.

This also moves a bunch of things that probably don't need to happen
in parallel (and don't happen in parallel in at least Gecko and WebKit)
out of the async steps.
johnwilander pushed a commit that referenced this issue Apr 20, 2021
@johannhof @annevk
Fix async steps in hasStorageAccess and requestStorageAccess. (#70)
378a889 
* Always require activation for requestStorageAccess (fixes #36)

This also removes outdated references to the WebKit and Gecko code,
both of which now also need to change to adhere to the new spec.

* Fix async steps in hasStorageAccess and requestStorageAccess.

Fixes #50, #69

This is based on some of Anne's feedback around how we run async steps
in parallel and queue tasks for resolving promises instead of what we
were doing before.

This also moves a bunch of things that probably don't need to happen
in parallel (and don't happen in parallel in at least Gecko and WebKit)
out of the async steps.

* Apply suggestions from code review

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hober hober

Labels
needs edit This issue is waiting on a PR to be written.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix async steps in hasStorageAccess and requestStorageAccess. johannhof/storage-access
3 participants
@hober @annevk @Dinh710