Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Feat/#448 implement ErrorOutOfGasLog error state #469

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

KimiWu123
Copy link
Contributor

fixed #448

@KimiWu123 KimiWu123 self-assigned this Jul 19, 2023
@KimiWu123 KimiWu123 force-pushed the feat/#448-Implement-ErrorOutOfGasLOG-error-state branch from 71a67fb to c3c7b97 Compare July 19, 2023 09:02
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nitpick

src/zkevm_specs/evm_circuit/execution/error_oog_log.py Outdated Show resolved Hide resolved
KimiWu123 and others added 2 commits July 20, 2023 09:56
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KimiWu123 KimiWu123 merged commit b506bb7 into master Jul 21, 2023
1 check passed
@KimiWu123 KimiWu123 deleted the feat/#448-Implement-ErrorOutOfGasLOG-error-state branch September 6, 2023 06:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ErrorOutOfGasLOG error state
3 participants