Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Feat/#442 implement error insufficient balance in callop #465

Merged
merged 7 commits into from
Jul 20, 2023
Merged

Feat/#442 implement error insufficient balance in callop #465

merged 7 commits into from
Jul 20, 2023

Conversation

KimiWu123
Copy link
Contributor

fixed #442

@KimiWu123 KimiWu123 self-assigned this Jul 12, 2023
rrtoledo
rrtoledo reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@rrtoledo rrtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for one word_to_address LGTM!

src/zkevm_specs/evm_circuit/execution/callop.py Outdated Show resolved Hide resolved
rrtoledo
rrtoledo approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@rrtoledo rrtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

ChihChengLiang
ChihChengLiang approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments are addressed.

src/zkevm_specs/evm_circuit/execution/callop.py Outdated Show resolved Hide resolved
src/zkevm_specs/evm_circuit/execution/callop.py Outdated Show resolved Hide resolved
src/zkevm_specs/evm_circuit/execution/callop.py Show resolved Hide resolved
src/zkevm_specs/evm_circuit/util/call_gadget.py Show resolved Hide resolved
tests/evm/test_callop.py Show resolved Hide resolved
tests/evm/test_callop.py Outdated Show resolved Hide resolved
KimiWu123 and others added 4 commits July 20, 2023 10:03
@KimiWu123 @ChihChengLiang
Update src/zkevm_specs/evm_circuit/execution/callop.py
77c474c 
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
@KimiWu123 @ChihChengLiang
Update src/zkevm_specs/evm_circuit/execution/callop.py
071e896 
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
@KimiWu123 @ChihChengLiang
Update tests/evm/test_callop.py
e9e0de6 
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
@KimiWu123
chore: fix lint
985a7b4
@KimiWu123 KimiWu123 merged commit 7f94a35 into master Jul 20, 2023
1 check passed
@KimiWu123 KimiWu123 deleted the feat/#442-Implement-ErrorInsufficientBalance-in-callop branch September 6, 2023 06:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

@rrtoledo rrtoledo rrtoledo approved these changes

Assignees

@KimiWu123 KimiWu123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ErrorInsufficientBalance in callop
3 participants
@KimiWu123 @ChihChengLiang @rrtoledo