Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

merge queue fixes #1216

Merged
merged 1 commit into from
Feb 16, 2023
Merged

merge queue fixes #1216

merged 1 commit into from
Feb 16, 2023

Conversation

pinkiebell
Copy link
Contributor

@pinkiebell pinkiebell commented Feb 16, 2023

Description

Make some modifications to the required workflow files in an attempt to fix the merge queue not triggering workflows.

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@github-actions github-actions bot added the CI Issues related to the Continuous Integration mechanisms of the repository. label Feb 16, 2023
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦧 Ape approval

@pinkiebell pinkiebell added this pull request to the merge queue Feb 16, 2023
Merged via the queue into main with commit 26ed1fd Feb 16, 2023
@pinkiebell pinkiebell deleted the ci-test branch February 16, 2023 13:31
cameron1024 pushed a commit to cameron1024/zkevm-circuits that referenced this pull request Jun 30, 2024
* Update l1geth

* trigger ci?

* bump go version

* Update ci.yml

* Update scroll-tech/go-ethereum

* bump go version

* remove toolchain

* register structLogTracer at init

* Upgrade to go 1.21 and go mod tidy

* ignore test in default case for now

* undo change

* fix callTrace

---------

Co-authored-by: Mason Liang <mason@scroll.io>
Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
Co-authored-by: lightsing <light.tsing@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI Issues related to the Continuous Integration mechanisms of the repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants