This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Migrate multi-packed keccak witness assignment to Value<F>
API
#942
Labels
crate-keccak
Issues related to the keccak workspace member
T-refactor
Type: cleanup/refactor
T-tech-debt
Type: tech-debt generated or cleaned up
wontfix
This will not be worked on
I made an effort to migrate
Part<F>
andPartValue<F>
and the witness assignment/generation in general to use theValue<F>
struct from halo2 API in #925.During the process, I found several problems on the path that discouraged me from continuing with the task although I think is doable without changes to the Halo2
Value
API..map()
to gain access to the underlyingF
so that you can do extra things with it such as decompose it into bytes actually).PartialEq
it's challenging to perform some sanity checks.XOR
/AND
are not implemented forValue
. And that also complicates certain things as you need again to nest multiplemap()
s to perform the operations with the underlying F's.For these reasons, right now
extract_field
function was added. And the goal is to get ridd of it fixing the witness assignment/generation to be done with theValue<F>
API.The text was updated successfully, but these errors were encountered: