Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track field update #1530

Merged
merged 2 commits into from
Jan 16, 2025
Merged

feat: track field update #1530

merged 2 commits into from
Jan 16, 2025

Conversation

xrutayisire
Copy link
Collaborator

@xrutayisire xrutayisire commented Jan 16, 2025

Resolves: DT-2586: AAPrismicPM I can track an update of a field in SM

Description

From Dani message in Slack: https://prismic-team.slack.com/archives/C02L3FN3AJK/p1734610823448939?thread_ts=1734552453.615859&cid=C02L3FN3AJK

  • Track when a field is updated
  • Same properties as when a field is added
  • Two new properties to know when a field id has been changed (previousId + idUpdated)
  • Fix a typo with "Group added" instead of "Field added"
  • Prevent triggering double tracking update when adding a field inside a group

TODO:

  • Update Segment for Stage
  • Update Segment for Prod

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@xrutayisire xrutayisire requested a review from a team as a code owner January 16, 2025 09:46
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Jan 16, 2025 10:01am

@xrutayisire xrutayisire marked this pull request as draft January 16, 2025 09:48
@xrutayisire xrutayisire marked this pull request as ready for review January 16, 2025 09:53
Copy link
Contributor

@jomifepe jomifepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me 💯

@xrutayisire xrutayisire merged commit 0619073 into main Jan 16, 2025
32 checks passed
@xrutayisire xrutayisire deleted the xru/track-field-update branch January 16, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants