feat(adapter-*): update page snippets with meta image #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xrutayisire
reviewed
Jan 3, 2025
xrutayisire
reviewed
Jan 3, 2025
| import { repositoryName } from \\"$lib/prismicio\\"; | ||
| </script> | ||
|
|
||
| <svelte:head> | ||
| <title>{$page?.data.title}</title> |
There was a problem hiding this comment.
❓ No check that title is defined both title and meta?
There was a problem hiding this comment.
I think it's just page that might be undefined and title tag is mandatory-ish. Not sure if we want to do that check for the og:title meta 🤔
xrutayisire
approved these changes
Jan 3, 2025
lihbr
changed the title
useSeoMeta()
lihbr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: nuxt-modules/prismic#222
Description
This pull request updates Nuxt pages snippets to use the modern equivalent of
useHead:useSeoMeta, also taking into account meta image.Checklist
Preview
N/A
How to QA 1
Try the new page snippet with:
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩