Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for repeatable links in models #355

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

levimykel
Copy link
Contributor

@levimykel levimykel commented Oct 28, 2024

Resolves: Repeatable links project

Description

The first of 3 PRs to support an array of links as well as single links. It would allow devs to not manually wrap their link in a Group. It would also allow editors to have a better experience with a dedicated UI for multiple links.

This PR handles the model changes. The model adds a new repeat property to define if the link field is an array or not.

{
  "example_link": {
    "type": "Link",
    "config": {
      "label": "My Button Link",
      "placeholder": "My Button Link Placeholder",
      "repeat": false, // true to activate repetition
      "select": null,
      "allowTargetBlank": false,
      "allowText": true
    }
  }
}

Other PRS:

Checklist

  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@levimykel levimykel changed the title Lg/repeatable links feat: add support for repeatable links in models Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant