Remove obsolete @ts-expect-error

prismicio · Sep 25, 2024 · 986284b · 986284b
1 parent d0d3c90
commit 986284b
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 26 deletions.
diff --git a/src/Migration.ts b/src/Migration.ts
@@ -410,17 +410,13 @@ export class Migration<TDocuments extends PrismicDocument = PrismicDocument> {
 					// ID needs to be 16 characters long to be considered valid by the API
 					id: "_____broken_____",
 					isBroken: true,
-					// TODO: Remove when link text PR is merged
-					// @ts-expect-error - Future-proofing for link text
 					text: input.text,
 				}
 			}
 
 			return {
 				link_type: LinkType.Document,
 				id: () => this._getByOriginalID(input.id),
-				// TODO: Remove when link text PR is merged
-				// @ts-expect-error - Future-proofing for link text
 				text: input.text,
 			}
 		}
@@ -429,8 +425,6 @@ export class Migration<TDocuments extends PrismicDocument = PrismicDocument> {
 			return {
 				link_type: LinkType.Media,
 				id: this.createAsset(input),
-				// TODO: Remove when link text PR is merged
-				// @ts-expect-error - Future-proofing for link text
 				text: input.text,
 			}
 		}

diff --git a/src/types/migration/Asset.ts b/src/types/migration/Asset.ts
@@ -75,14 +75,7 @@ export type MigrationLinkToMedia = Pick<
 	LinkToMediaField<"filled">,
 	"link_type"
 > &
-	Partial<
-		Pick<
-			LinkToMediaField<"filled">,
-			// TODO: Remove when link text PR is merged
-			// @ts-expect-error - Future-proofing for link text
-			"text"
-		>
-	> & {
+	Partial<Pick<LinkToMediaField<"filled">, "text">> & {
 		/**
 		 * A reference to the migration asset used to resolve the link to media
 		 * field's value.
@@ -95,8 +88,6 @@ export type MigrationLinkToMedia = Pick<
  * with the migration API.
  */
 export type MigrationLinkToMediaField =
-	// TODO: Remove when link text PR is merged
-	// @ts-expect-error - Future-proofing for link text
 	| Pick<LinkToMediaField<"filled">, "link_type" | "id" | "text">
 	| EmptyLinkField<"Media">
 

diff --git a/src/types/migration/ContentRelationship.ts b/src/types/migration/ContentRelationship.ts
@@ -14,14 +14,7 @@ export type MigrationContentRelationship<
 > =
 	| ValueOrThunk<TDocuments | PrismicMigrationDocument<TDocuments> | undefined>
 	| (Pick<FilledContentRelationshipField, "link_type"> &
-			Partial<
-				Pick<
-					FilledContentRelationshipField,
-					// TODO: Remove when link text PR is merged
-					// @ts-expect-error - Future-proofing for link text
-					"text"
-				>
-			> & {
+			Partial<Pick<FilledContentRelationshipField, "text">> & {
 				id: ValueOrThunk<
 					TDocuments | PrismicMigrationDocument<TDocuments> | undefined
 				>

diff --git a/test/writeClient-migrate-patch-linkToMedia.test.ts b/test/writeClient-migrate-patch-linkToMedia.test.ts
@@ -22,8 +22,6 @@ const assetToLinkToMedia = (
 		size: `${asset.size}`,
 		height: typeof asset.height === "number" ? `${asset.height}` : undefined,
 		width: typeof asset.width === "number" ? `${asset.width}` : undefined,
-		// TODO: Remove when link text PR is merged
-		// @ts-expect-error - Future-proofing for link text
 		text,
 	}
 }