refactor: escape all attributes with default serializer

prismicio · Oct 4, 2023 · 52ad75d · 52ad75d
1 parent 8e5da1a
commit 52ad75d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/lib/serializerHelpers.ts b/src/lib/serializerHelpers.ts
@@ -31,7 +31,7 @@ const formatAttributes = (node: RTAnyNode, attributes: Attributes): string => {
 			if (typeof value === "boolean") {
 				result.push(key);
 			} else {
-				result.push(`${key}="${value}"`);
+				result.push(`${key}="${escapeHTML(value)}"`);
 			}
 		}
 	}
@@ -93,8 +93,8 @@ export const serializeImage = (
 		const attributes = {
 			...generalAttributes,
 			src: node.url,
-			alt: node.alt && escapeHTML(node.alt),
-			copyright: node.copyright && escapeHTML(node.copyright),
+			alt: node.alt,
+			copyright: node.copyright,
 		};
 
 		let imageTag = `<img${formatAttributes(node, attributes)} />`;
@@ -153,7 +153,7 @@ export const serializeHyperlink = (
 		};
 
 		if (node.data.link_type === LinkType.Web) {
-			attributes.href = escapeHTML(node.data.url);
+			attributes.href = node.data.url;
 			attributes.target = node.data.target;
 			attributes.rel = "noopener noreferrer";
 		} else if (node.data.link_type === LinkType.Document) {