Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): pass through connection_info #5125

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

FGoessler
Copy link
Contributor

Implements ORM-472 and enables to use various SQL dialects and not just the previously hardcoded postgres one.

@FGoessler FGoessler requested a review from a team as a code owner January 15, 2025 11:48
@FGoessler FGoessler requested review from jacek-prisma and removed request for a team January 15, 2025 11:48
connection_info: &'a ConnectionInfo,
pub connection_info: &'a ConnectionInfo,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to make this public to access the ConnectionInfo from within build_db_query as it currently only has the context available. Could also pass the ConnectionInfo directly as additional arg through translate_read_query / translate_write_query. Wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably make this private again after my PR is merged

@FGoessler
Copy link
Contributor Author

Also noticed this in the changeset:
Screenshot 2025-01-15 at 12 55 40

Something ORM-472 is supposed to tackle or is this a different issue? 🤔

Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #5125 will not alter performance

Comparing feat/ORM-472-forward-connection-info (6c08ce3) with compiler (6b19a39)

Summary

✅ 11 untouched benchmarks

@jacek-prisma
Copy link
Contributor

Also noticed this in the changeset: Screenshot 2025-01-15 at 12 55 40

Something ORM-472 is supposed to tackle or is this a different issue? 🤔

I think I can delete this in #5127, or soon after

@FGoessler
Copy link
Contributor Author

Am also running into issues with the conditionally out-compiled stuff based on the given database. See CI here: https://github.com/prisma/prisma-engines/actions/runs/12788035515/job/35648540139?pr=5125

Don't know how to solve this. 🤔 Guess also something where I've better gotta wait for @jacek-prisma's extraction?

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.147MiB 2.146MiB 844.000B
Postgres (gzip) 861.735KiB 860.921KiB 833.000B
Mysql 2.186MiB 2.185MiB 909.000B
Mysql (gzip) 872.266KiB 871.827KiB 450.000B
Sqlite 2.148MiB 2.147MiB 908.000B
Sqlite (gzip) 856.215KiB 855.655KiB 574.000B

@FGoessler FGoessler merged commit 9cd8301 into compiler Jan 15, 2025
338 of 339 checks passed
@FGoessler FGoessler deleted the feat/ORM-472-forward-connection-info branch January 15, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants