-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler): pass through connection_info #5125
Conversation
connection_info: &'a ConnectionInfo, | ||
pub connection_info: &'a ConnectionInfo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to make this public to access the ConnectionInfo
from within build_db_query
as it currently only has the context
available. Could also pass the ConnectionInfo
directly as additional arg through translate_read_query / translate_write_query
. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can probably make this private again after my PR is merged
CodSpeed Performance ReportMerging #5125 will not alter performanceComparing Summary
|
I think I can delete this in #5127, or soon after |
Am also running into issues with the conditionally out-compiled stuff based on the given database. See CI here: https://github.com/prisma/prisma-engines/actions/runs/12788035515/job/35648540139?pr=5125 Don't know how to solve this. 🤔 Guess also something where I've better gotta wait for @jacek-prisma's extraction? |
WASM Query Engine file Size
|
Implements ORM-472 and enables to use various SQL dialects and not just the previously hardcoded postgres one.